Re: pkg/44317: Request for update geography/qlandkartegt

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/44317; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/44317: Request for update geography/qlandkartegt
Date: Mon, 3 Jan 2011 01:00:43 +0100

 On Sun, Jan 02, 2011 at 11:15:01PM +0000, H_Muehlmeier%gmx.de@localhost wrote:
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/geography/qlandkartegt/Makefile,v
 > retrieving revision 1.6
 > diff -u -p -r1.6 Makefile
 > --- Makefile    15 Nov 2010 22:57:08 -0000      1.6
 > +++ Makefile    2 Jan 2011 23:12:32 -0000
 > @@ -1,8 +1,8 @@
 >  # $NetBSD: Makefile,v 1.6 2010/11/15 22:57:08 abs Exp $
 >  #
 >  
 > -DISTNAME=      qlandkartegt-0.18.0
 > -PKGREVISION=   3
 > +VERSION=       0.19.2
 > +DISTNAME=      qlandkartegt-${VERSION}
 >  CATEGORIES=    geography
 >  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=qlandkartegt/}
 >  
 > @@ -13,7 +13,7 @@ LICENSE=      gnu-gpl-v2
 >  
 >  PKG_DESTDIR_SUPPORT=   user-destdir
 >  
 > -WRKSRC=                ${WRKDIR}/qlandkartegt-0.18.0
 > +WRKSRC=                ${WRKDIR}/qlandkartegt-${VERSION}
 >  USE_LANGUAGES= c c++
 >  USE_CMAKE=     yes
 >  
 
 Isn't the WRKSRC assignment (and therefore the VERSION dance) redundant?
 
 > Index: PLIST
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/geography/qlandkartegt/PLIST,v
 > retrieving revision 1.3
 > diff -u -p -r1.3 PLIST
 > --- PLIST       19 Mar 2010 21:58:04 -0000      1.3
 > +++ PLIST       2 Jan 2011 23:12:32 -0000
 > @@ -1,11 +1,11 @@
 > -@comment $NetBSD: PLIST,v 1.3 2010/03/19 21:58:04 jkunz Exp $
 > +@comment $NetBSD$
 >  bin/qlandkartegt
 > +share/applications/qlandkartegt.desktop
 > +share/man/man1/qlandkartegt.1
 > +share/pixmaps/qlandkartegt.png
 >  share/qlandkartegt/translations/qlandkartegt_de_DE.qm
 >  share/qlandkartegt/translations/qlandkartegt_es_ES.qm
 >  share/qlandkartegt/translations/qlandkartegt_fr_FR.qm
 >  share/qlandkartegt/translations/qlandkartegt_it_IT.qm
 >  share/qlandkartegt/translations/qlandkartegt_nl_NL.qm
 >  share/qlandkartegt/translations/qlandkartegt_ru_RU.qm
 > -share/applications/qlandkartegt.desktop
 > -share/man/man1/qlandkartegt.1
 > -share/pixmaps/qlandkartegt.png
 
 Wrong location of man page.
 
 Joerg