Re: pkg/44257 (comms/asterisk18 fails to build on DragonFly)

[Francois Tigeot <ftigeot%wolfpond.org@localhost>]

The following reply was made to PR pkg/44257; it has been noted by GNATS.

From: Francois Tigeot <ftigeot%wolfpond.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: John Nemeth <jnemeth%CornerstoneService.ca@localhost>, 
jnemeth%NetBSD.org@localhost,
        gnats-admin%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost
Subject: Re: pkg/44257 (comms/asterisk18 fails to build on DragonFly)
Date: Tue, 21 Dec 2010 10:09:54 +0100

 John Nemeth wrote:
 > The following reply was made to PR pkg/44257; it has been noted by GNATS.
 >
 > From: jnemeth%CornerstoneService.ca@localhost (John Nemeth)
 > To: gnats-bugs%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost, 
 > ftigeot%wolfpond.org@localhost
 > Cc:
 > Subject: Re: pkg/44257 (comms/asterisk18 fails to build on DragonFly)
 > Date: Mon, 20 Dec 2010 22:57:08 -0800
 >
 >        There are various other places that have #defined(__FreeBSD__)
 >   but don't have #defined(__DragonFly__).  Can you check if any of
 >   these other places should be modified as well, please?  Here is a
 >   list of them:
 >
 >   apps/app_voicemail.c
 This one is okay. This was a conditional inclusion of a .h file; the 
 compilation succeeded and would have failed otherwise.
 
 >   channels/chan_usbradio.c
 >   channels/chan_dahdi.c
 I'm unsure; they don't seem to be compiled by default.
 
 >   channels/chan_sip.c:23834:#if !defined(__FreeBSD__)
 This concerns some socket error management details. I don't know enough 
 about it to judge.
 
 >   channels/chan_oss.c:210:#if defined(__FreeBSD__)
 Some sound management details. I dont' know enough either.
 
 >   codecs/codec_resample.c:39:#if defined(__Darwin__) || defined(__OpenBSD__) 
 > || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__CYGWIN__)
 
 This is a conditional to include <float.h>
 Although the fine was compiled, we also need a __DragonFly__ here.
 
 >   include/asterisk/endian.h:39:
 
 It's fine. There's already a __DragonFly__ test just above.
 
 >   main/db1-ast/include/db.h:58:#if (!defined(__FreeBSD__)&&  
 > !defined(__NetBSD__)&&  !defined(__APPLE__))
 
 This file wants to redefine standard C types.
 This may pose problem on non-i386 architectures. We should also add a 
 __DragonFly__ just to be sure.
 
 >   main/acl.c:32:#if defined(__OpenBSD__) || defined(__NetBSD__) || 
 > defined(__FreeBSD__) || defined(__Darwin__)
 This line looks okay.
 
 >   main/acl.c:126:#if defined(__OpenBSD__) || defined(__NetBSD__) || 
 > defined(__FreeBSD__) || defined(__linux__) || defined(__Darwin__)
 >   main/acl.c:135:#if defined(__OpenBSD__) || defined(__NetBSD__) || 
 > defined(__FreeBSD__) || defined(__linux__) || defined(__Darwin__)
 >   main/acl.c:146:#if defined(__OpenBSD__) || defined(__NetBSD__) || 
 > defined(__FreeBSD__) || defined(__linux__) || defined(__Darwin__)
 >   main/acl.c:205:#if defined(__OpenBSD__) || defined(__NetBSD__) || 
 > defined(__FreeBSD__) || defined(__linux__) || defined(__Darwin__)
 
 Some network interface management code. I don't believe DragonFly is 
 different from the other BSDs and Linux. We should add a __DragonFly__ 
 on these four lines.
 
 >   main/asterisk.c:735:#if defined ( __i686__)&&  (defined(__FreeBSD__) || 
 > defined(
 >   linux))
 >   main/asterisk.c:736:#if defined(__FreeBSD__)
 
 Some inline Pentium-Pro machine langage code (RDTSC instructions).
 I don't like the look of it; we should do nothing and keep it disabled 
 for now.
 
 >   res/res_http_post.c:40:#if defined (__OpenBSD__) || defined(__FreeBSD__)
 
 Conditional include of libgen.h Seems to be fine.
 
 >   tests/test_locale.c:83:#if defined(__FreeBSD__) || defined(__OpenBSD__) || 
 > defined( __NetBSD__ ) || defined(__APPLE__)
 
 Test for the default location of the locale directory.
 We need a __DragonFly__ here.
 
 >   utils/extconf.c:3034:#if defined ( __i386__)&&  (defined(__FreeBSD__) || 
 > defined(linux))
 >   utils/extconf.c:3035:#if defined(__FreeBSD__)
 
 i386 machine language. This file is fine as-is.
 
 >   utils/muted.c:42:#elif defined(__linux__) || defined(__FreeBSD__)
 
 Soundcard support. I don't know enough about it to judge.
 
 >   utils/streamplayer.c.orig
 
 This is a .orig; no need to do anything.
 
 -- 
 Francois Tigeot