Re: pkg/30172 (games/xjewel build, install failures on MacOS X)

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

The following reply was made to PR pkg/30172; it has been noted by GNATS.

From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/30172 (games/xjewel build, install failures on MacOS X)
Date: Mon, 25 Oct 2010 11:12:46 -0500 (CDT)

 On Mon, 25 Oct 2010, dholland%NetBSD.org@localhost wrote:
 
 > Does this affect recent versions of MacOS?
 
 On MacOS X 10.4.11 (PPC), the first part still does, although in an
 abbreviated form:
 
 [...]
 make depend
 makedepend  --   -I/usr/pkg/include    -D__powerpc__ -D__DARWIN__              
                   -DNO_ALLOCA -DCSRG_BASED      
-DHSCORE_FILE=\"/var/games/xjewel.scores\"  -DICON_WINDOW -DGETPWENT  
-DUSE_MAKEDEPEND -- xw.c jewel.c logic.c panel.c xhscore.c hscore.c game.c 
intro.c help.c
 makedepend: warning:  xw.c (reading xw.h, line 50): cannot find include file 
"stropts.h"
        not in /usr/pkg/include/stropts.h
        not in /usr/include/stropts.h
 ===> Building for xjewel-1.6nb2
 gcc -O -Wall -Wpointer-arith -no-cpp-precomp     -I/usr/pkg/include    
-D__powerpc__ -D__DARWIN__                                 -DNO_ALLOCA 
-DCSRG_BASED      -DHSCORE_FILE=\"/var/games/xjewel.scores\"  -DICON_WINDOW 
-DGETPWENT  -no-cpp-precomp -isystem /usr/include -I/usr/pkg/include -c xw.c
 In file included from xw.c:34:
 xw.h:50:23: error: stropts.h: No such file or directory
 xw.c: In function 'xw_sync_sleep':
 xw.c:120: warning: passing argument 1 of 'poll' from incompatible pointer type
 xw.c: In function 'xw_init':
 xw.c:402: warning: implicit declaration of function 'toupper'
 *** Error code 1
 
 Stop.
 bmake: stopped in /Volumes/d0/tmp/pkgsrc/games/xjewel/work/xjewel-1.6
 *** Error code 1
 
 Stop.
 bmake: stopped in /usr/pkgsrc/games/xjewel
 *** Error code 1
 
 Stop.
 bmake: stopped in /usr/pkgsrc/games/xjewel
 [...]
 
 The fix proposed in the PR solves this problem.
 
 
 Since I created a user/group "games" in NetInfo, I can't really test
 the second problem, but would assume it still exists on unmodified
 MacOS systems.
 
 
 The third problem (/var/games/xjewel.scores) still exists.  It would be
 nice to have this package observe $VARBASE and create the subdirectory
 if it doesn't already exist.
 
 Looks like "HSCORE_FILE" can be modified in "Imakefile".  Suggest
 adding an "HSCORE_DIR" set to $(VARBASE)/games "HSCORE_FILE" be set to
 "$(HSCORE_DIR)/xjewel.scores".  Also, the install:: target should be
 prepended with "       $(MKDIRHIER) $(HSCORE_DIR)".
 
 (Just tried that.  Not sure how to get value of ${VARBASE} passed to
 imake automagically, or let it be evaluated later...)
 
 Made above changes, but hardcoded "HSCORE_DIR=/usr/pkg/var/games" to
 proceed.
 
 
 The fourth problem, manual page installation, seems to have been fixed.
 
 
 Looks like "patch-aa" does most things already.  Just need to add a bit
 more to handle the MacOS X and ${VARBASE} situations.
 
 A revised "patch-aa" would look like:
 
 --- Imakefile.orig     1994-02-16 04:35:06.000000000 -0600
 +++ Imakefile  2010-10-25 11:01:29.000000000 -0500
 @@ -4,12 +4,14 @@
   CDEBUGFLAGS = -O
 
   # CHANGE HSCORE_FILE TO SUIT
 -#HSCORE_FILE=/usr/local/lib/xjewel.scores
 -HSCORE_FILE=xjewel.scores
 +#HSCORE_DIR=$(VARBASE)/games
 +HSCORE_DIR=/usr/pkg/var/games
 +HSCORE_FILE=$(HSCORE_DIR)/xjewel.scores
 
   # ADD YOUR ARCHITECTURE IF YOU USE SELECT INSTEAD OF POLL
   #if defined(HPArchitecture) || defined(ApolloArchitecture) || \
 -      defined(UltrixArchitecture)
 +      defined(UltrixArchitecture) || defined(NetBSDArchitecture) || \
 +      defined(DragonFlyArchitecture)|| defined(DarwinArchitecture)
   #define sel -DUSE_SELECT
   #else
   #define sel 
 @@ -21,10 +23,10 @@
   # DEFINE 'GETPWENT' if you dont have the cuserid ftn (hscore.c)
   # DEFINE 'SLOW_FONTS=n' if your server is overly fast on fonts
   # DEFINE 'SLOW_DRAW=n' if your server is overly fast on drawing
 -USERDEFS = -DICON_WINDOW
 +USERDEFS = -DICON_WINDOW -DGETPWENT
 
   # CHANGE FFILE TO REFLECT THE EXTENSION USED FOR COMPILED FONTS
 -FFILE = snf
 +FFILE = pcf.gz
 
   
##############################################################################
   # X-STUFF...
 @@ -42,15 +44,20 @@
 
 
   # LETS GET TO IT...
 +INSTPGMFLAGS = -s -m 2555 -o root -g games
   ComplexProgramTarget(xjewel)
 
   # IF YOUR SERVER DOES NOT LIKE THE DEFAULT FONT COMPILER, EDIT HERE...
   FontTarget($(FONT))
        $(MKFONTDIR) bitmaps/
 
 +MANSUFFIX=6
 +
   # FORCE FONT TO BE BUILT
   all:: $(CFONT)
 
   install::
 -      touch  $(HSCORE_FILE)
 -      chmod a+w $(HSCORE_FILE)
 +      $(MKDIRHIER) $(HSCORE_DIR)
 +      touch $(HSCORE_FILE)
 +      chown games:games $(HSCORE_FILE)
 +      chmod 664 $(HSCORE_FILE)
 
 
 
 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645