pkg/43976: audio/sox link fails on i386-5.99.39

[jdbaker%mylinuxisp.com@localhost]

>Number:         43976
>Category:       pkg
>Synopsis:       audio/sox link fails on i386-5.99.39
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 15 22:20:01 +0000 2010
>Originator:     John D. Baker
>Release:        5.99.39/i386 ; pkgsrc-current
>Organization:
>Environment:
NetBSD shadow.bozonet.ntc 5.99.39 NetBSD 5.99.39 (SHADOW) #34: Wed Oct  6 
15:47:32 CDT 2010  
sysop%shadow.bozonet.ntc@localhost:/d0/nbsd/current/obj/i386/sys/arch/i386/compile/SHADOW
 i386

NetBSD fred.technoskunk.fur 5.99.39 NetBSD 5.99.39 (FRED) #50: Thu Oct  7 
21:49:51 CDT 2010  
sysop%fred.technoskunk.fur@localhost:/d0/build/current/obj/i386/sys/arch/i386/compile/FRED
 i386

>Description:
Building audio/sox on i386-5.99.39 fails to link with:

[...]
/bin/sh ../libtool --silent --tag=CC  --silent  --mode=link cc -Wconversion -O2 
-I/usr/pkg/include -D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes 
-Wstrict-prototypes -pedantic   -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -o sox sox.o  
libsox.la                         -lm
./.libs/libsox.so: undefined reference to `open_memstream'
*** Error code 1

Stop.
make: stopped in /d0/build/pkgsrc/audio/sox/work/sox-14.3.1/src
[...]

>How-To-Repeat:
Attempt to build audio/sox on i386-5.99.39.

For reference, it builds fine on i386-5.1_RC4.

>Fix:
The culprit seems to be a typographical error in

  ...work/sox-14.3.1/src/formats.c

[...]
      ft->fp =
#ifdef HAVE_FMEMOPEN
        buffer? fmemopen(buffer, buffer_size, "w+b") :
        buffer_ptr? open_memstream(buffer_ptr, buffer_size_ptr) :
#endif
        fopen(path, "w+b");
[...]

Since "fmemopen(3)" is in -current but not in netbsd-5, it builds on
the netbsd-5 branch, but trips up on this in -current.

The only function prototypes/definitions with "open_memstream" in
the name is "open_memstream_write()", so I'd assume this is what was
intended.

This is really an upstream problem, however.