pkg/43969: graphics/cairo does not build on netbsd-4

[Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost>]

>Number:         43969
>Category:       pkg
>Synopsis:       graphics/cairo does not build on netbsd-4
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 14 10:30:00 +0000 2010
>Originator:     Hauke Fath
>Release:        NetBSD 4.0_STABLE
>Organization:
Falling Raindrops
>Environment:
        
        
System: NetBSD pizza.causeuse.org 4.0_STABLE NetBSD 4.0_STABLE (PIZZA_PF) #0: 
Tue May 18 16:36:44 CEST 2010 
hf@Hochstuhl:/var/obj/netbsd-builds/4/sparc/sys/arch/sparc/compile/PIZZA_PF 
sparc
Architecture: sparc
Machine: sparc
>Description:

        graphics/cairo comes with default options x11 and xcb. I
        mentioned a while back that libxcb does not build on netbsd-4,
        because it has dependencies that are not satisfied by the
        netbsd-4 X11 or cannot be built here. But even a build with
        "PKG_OPTIONS.cairo = x11 -xcb" breaks:

[...]
cairo-xlib-display.c: In function '_cairo_xlib_display_get_xrender_format':
cairo-xlib-display.c:559: warning: 'pict_format' may be used uninitialized in 
this function
  CC     cairo-xlib-screen.lo
cairo-xlib-screen.c: In function '_cairo_xlib_screen_get_gc':
cairo-xlib-screen.c:359: warning: comparison between signed and unsigned
  CC     cairo-xlib-surface.lo
cairo-xlib-surface.c: In function '_cairo_xlib_surface_acquire_pattern_surface':
cairo-xlib-surface.c:2133: error: 'XLinearGradient' undeclared (first use in 
this function)
cairo-xlib-surface.c:2133: error: (Each undeclared identifier is reported only 
once
cairo-xlib-surface.c:2133: error: for each function it appears in.)
cairo-xlib-surface.c:2133: error: expected ';' before 'grad'
cairo-xlib-surface.c:2135: warning: ISO C90 forbids mixed declarations and code
cairo-xlib-surface.c:2161: error: 'grad' undeclared (first use in this function)
cairo-xlib-surface.c:2176: error: implicit declaration of function 
'XRenderCreateLinearGradient'
cairo-xlib-surface.c:2176: warning: nested extern declaration of 
'XRenderCreateLinearGradient'
cairo-xlib-surface.c:2181: error: 'XRadialGradient' undeclared (first use in 
this function)
cairo-xlib-surface.c:2181: error: expected ';' before 'grad'
cairo-xlib-surface.c:2191: error: implicit declaration of function 
'XRenderCreateRadialGradient'
cairo-xlib-surface.c:2191: warning: nested extern declaration of 
'XRenderCreateRadialGradient'
*** Error code 1

        
        Currently installed on the machine is cairo-1.8.10, so that
        one built fine.

        I made the PR "critical" because of the many packages that
        depend on cairo these days.

>How-To-Repeat:

        Build cairo (or any of the umpteen packages which depend on it) on 
netbsd-4.

>Fix:
        Yes, please.

>Unformatted: