pkg/43920: pkgsrc/net/nagios-nrpe add options MK support for --enable-command-args

[bseklecki%collaborativefusion.com@localhost]

>Number:         43920
>Category:       pkg
>Synopsis:       pkgsrc/net/nagios-nrpe add options MK support for 
>--enable-command-args
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 28 16:10:00 +0000 2010
>Originator:     Brian A. Seklecki
>Release:        NetBSD metrotitan 5.99.39 NetBSD 5.99.39 (GENERIC) #1: Fri Sep 
>17 14:46:31 EDT 2010  
>root%cauldron-nbsd-netbsd-6-i386.lab02.pitbpa0.priv.collaborativefusion.com@localhost:/home/netbsd/obj.i386/20100916-1706EDT/sys/arch/i386/compile/GENERIC
> i386
>Organization:
Collaborative Fusion, Inc.
>Environment:
NetBSD metrotitan 5.99.39 NetBSD 5.99.39 (GENERIC) #1: Fri Sep 17 14:46:31 EDT 
2010  
root%cauldron-nbsd-netbsd-6-i386.lab02.pitbpa0.priv.collaborativefusion.com@localhost:/home/netbsd/obj.i386/20100916-1706EDT/sys/arch/i386/compile/GENERIC
 i386
>Description:
This package is unmaintained.  By both the original author and there is no 
NetBSD Pkg maintainer.

Adding this MK option flag sync's it with FreeBSD's port.

This command line argument is pragmatic in all but enterprise organizations 
that can use Puppet or other system to distribute a system-specific NRPE config 
file to the system with all the system-specific args specified therein.

For other organizations using IP ACLs, TLS, and internal code audits, command 
line arguments are an acceptable trade off and minimalized attack vector if 
NRPE2 is run as a non-root user and given elevated access on a per-check basis 
with sudo(8)
>How-To-Repeat:
# diff -u options.mk.orig options.mk
--- options.mk.orig     2010-09-28 11:14:20.000000000 -0400
+++ options.mk  2010-09-28 11:16:51.000000000 -0400
@@ -1,7 +1,7 @@
 # $NetBSD: options.mk,v 1.2 2007/02/22 19:26:56 wiz Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.nagios-nrpe
-PKG_SUPPORTED_OPTIONS= ssl tcpwrappers
+PKG_SUPPORTED_OPTIONS= ssl tcpwrappers args
 PKG_SUGGESTED_OPTIONS= tcpwrappers
 
 .include "../../mk/bsd.options.mk"
@@ -13,6 +13,13 @@
 CONFIGURE_ARGS+=       --disable-ssl
 .endif
 
+.if !empty(PKG_OPTIONS:Margs)
+CONFIGURE_ARGS+=       --enable-command-args
+.else
+CONFIGURE_ARGS+=       --disable-command-args
+.endif
+
+
 .if !empty(PKG_OPTIONS:Mtcpwrappers)
 .  include "../../security/tcp_wrappers/buildlink3.mk"
 .endif

>Fix:
See patch above.