Re: pkg/43465 (devel/boost-libs PLIST incorrect)

[Tim Zingelman <tez%netbsd.org@localhost>]

Hauke,

It appears this MIGHT actually be a gcc issue??  In my environment,
the compiler flag -fvisibility=hidden is passed (see below,) but that
is not supported by older gcc versions (sorry not sure which version
got it added... looks like maybe added in 4.0, but I see you are using
4.1.2?)  Anyhow, below is the error seen when building with gcc-3.4.6
on Solaris:

common.mkdir bin.v2/libs/math/build/gcc-3.4.6/release/link-static
common.mkdir 
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi
common.mkdir 
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/..
common.mkdir 
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src
common.mkdir 
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src/tr1
gcc.compile.c++.pch
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src/tr1/pch.hpp.gch
cc1plus: error: unrecognized command line option "-fvisibility=hidden"

    "g++" -x c++-header -O3 -finline-functions -Wno-inline -Wall
-pthreads -fvisibility=hidden -DBOOST_ALL_NO_LIB=1
-DBOOST_BUILD_PCH_ENABLED -DNDEBUG -I"." -I"libs/math/src/tr1" -c -o
"bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src/tr1/pch.hpp.gch"
"libs/math/build/../src/tr1/pch.hpp"

...failed gcc.compile.c++.pch
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src/tr1/pch.hpp.gch...
...skipped 
<pbin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi>assoc_laguerre.o
for lack of 
<pbin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi>../src/tr1/pch.hpp.gch...


I got the library to compile and install cleanly by adding:
  BUILDLINK_TRANSFORM+=   rm:-fvisibility=hidden
to the Makefile.  I am unclear what affect this has on the resulting
library... apparently some internal functions will be visible that
should be hidden, but unless those cause a name collision, I think it
would not affect use of the libraries.  It does seem that this was
added very recently to boost, as prior version did not show this error
in the same build environment.

Perhaps wrapping the above in .if !empty(CC_VERSION:Mgcc-[23]) .endif
would be ok?

The existing info in the PR does not include the lines above
"...failed gcc.compile.c++.pch
bin.v2/libs/math/build/gcc-3.4.6/release/link-static/threading-multi/../src/tr1/pch.hpp.gch..."
which would indicate the actual failure and if it was the same as the
one I see or something else?

Could you try building with the BUILDLINK_TRANSFORM line added to your
Makefile, and/or provide the errors encountered above the ...failed
line?

Thanks,

 - Tim