pkg/43513: eggdbus fails to build on Linux

[cheusov%tut.by@localhost]

>Number:         43513
>Category:       pkg
>Synopsis:       sysutils/eggdbus fails to build on Linux [patch]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 25 14:50:00 +0000 2010
>Originator:     Aleksey Cheusov
>Release:        Linux glibc-2.3.6
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: Linux centos.imb.invention.com 2.6.18 #1 SMP Fri Apr 2 16:16:54 EDT 
2010 i686 i686 i386 GNU/Linux
Architecture: i686

>Description:
Build of eggdbus fails like this

   /bin/sh ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. 
-I../.. -I../../src -I../../src -DPACKAGE_LIBEXEC_DIR=\""/usr/pkg/libexec"\" 
-DPACKAGE_SYSCONF_DIR=\""/usr/pkg/etc"\" 
-DPACKAGE_DATA_DIR=\""/usr/pkg/share"\" -DPACKAGE_BIN_DIR=\""/usr/pkg/bin"\" 
-DPACKAGE_LOCALSTATE_DIR=\""/usr/pkg/var"\" 
-DPACKAGE_LOCALE_DIR=\""/usr/pkg/share/locale"\" 
-DPACKAGE_LIB_DIR=\""/usr/pkg/lib"\" -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT   
-I/usr/pkg/include -I/usr/include -D_EGG_DBUS_COMPILATION -pthread 
-I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include   -pthread 
-I/usr/pkg/include/dbus-1.0 -I/usr/pkg/lib/dbus-1.0/include 
-I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include    -Wno-error 
-I/usr/pkg/include -I/usr/include -Wall -Wchar-subscripts 
-Wmissing-declarations -Wnested-externs -Wpointer-arith -Wcast-align 
-Wsign-compare -Wformat -Wformat-security -MT 
libeggdbus_1_la-eggdbusintrospectable.lo -MD -MP -MF 
.deps/libeggdbus_1_la-eggdbusintrospect
 able.Tpo -c -o libeggdbus_1_la-eggdbusintrospectable.lo `test -f 
'eggdbusintrospectable.c' || echo './'`eggdbusintrospectable.c
   libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src 
-DPACKAGE_LIBEXEC_DIR=\"/usr/pkg/libexec\" 
-DPACKAGE_SYSCONF_DIR=\"/usr/pkg/etc\" -DPACKAGE_DATA_DIR=\"/usr/pkg/share\" 
-DPACKAGE_BIN_DIR=\"/usr/pkg/bin\" -DPACKAGE_LOCALSTATE_DIR=\"/usr/pkg/var\" 
-DPACKAGE_LOCALE_DIR=\"/usr/pkg/share/locale\" 
-DPACKAGE_LIB_DIR=\"/usr/pkg/lib\" -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT 
-I/tmp/obj_pkgsrc/sysutils/eggdbus/work/.buildlink/include 
-D_EGG_DBUS_COMPILATION -pthread 
-I/tmp/obj_pkgsrc/sysutils/eggdbus/work/.buildlink/include/glib/glib-2.0 
-I/tmp/obj_pkgsrc/sysutils/eggdbus/work/.buildlink/lib/glib-2.0/include 
-pthread -I/tmp/obj_pkgsrc/sysutils/eggdbus/work/.buildlink/include/dbus-1.0 
-I/tmp/obj_pkgsrc/sysutils/eggdbus/work/.buildlink/lib/dbus-1.0/include 
-Wno-error -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs 
-Wpointer-arith -Wcast-align -Wsign-compare -Wformat -Wformat-security -MT 
libeggdbus_1_la-eggdbusintrospectable.lo -MD -MP -MF .deps/libeggdbus
 _1_la-eggdbusintrospectable.Tpo -c eggdbusintrospectable.c  -fPIC -DPIC -o 
.libs/libeggdbus_1_la-eggdbusintrospectable.o
   In file included from ../../src/eggdbus/eggdbus.h:51,
                 from eggdbusintrospectable.c:11:
   ../../src/eggdbus/eggdbusbus.h:261: error: expected declaration specifiers 
or '...' before 'uid_t'
   ../../src/eggdbus/eggdbusbus.h:269: error: expected declaration specifiers 
or '...' before 'pid_t'
   ../../src/eggdbus/eggdbusbus.h:476: error: expected declaration specifiers 
or '...' before 'uid_t'
   ../../src/eggdbus/eggdbusbus.h:490: error: expected declaration specifiers 
or '...' before 'pid_t'
   ../../src/eggdbus/eggdbusbus.h:594: error: expected declaration specifiers 
or '...' before 'uid_t'
   ../../src/eggdbus/eggdbusbus.h:598: error: expected declaration specifiers 
or '...' before 'pid_t'
   gmake[4]: *** [libeggdbus_1_la-eggdbusintrospectable.lo] Error 1
>How-To-Repeat:
Linux + glibc-2.3.6
>Fix:
This happened because pid_t, uid_t and some other types were not defined.
The problem may be not reproduced on more recent versions of glibc.

The following patch solves the problem.
Alternatively
#include <sys/types.h>
may be added to src/eggdbus/eggdbusbus.h.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/eggdbus/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile    1 Jun 2010 10:51:04 -0000       1.1.1.1
+++ Makefile    25 Jun 2010 12:56:23 -0000
@@ -19,6 +19,8 @@
 TEST_TARGET=   check
 PKGCONFIG_OVERRIDE+=   eggdbus-1.pc.in
 
+CFLAGS.Linux+= -D_GNU_SOURCE
+
 pre-configure:
        cd ${WRKSRC} && ./autogen.sh