Re: pkg/43267: multimedia/dvdrip can't transcode movies - transcode does not compile with needed options enabled

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

The following reply was made to PR pkg/43267; it has been noted by GNATS.

From: Matthias Drochner <M.Drochner%fz-juelich.de@localhost>
To: <H_Muehlmeier%gmx.de@localhost>
Cc: <gnats-bugs%netbsd.org@localhost>
Subject: Re: pkg/43267: multimedia/dvdrip can't transcode movies - transcode 
 does not compile with needed options enabled
Date: Thu, 6 May 2010 19:15:30 +0200

 --==_Exmh_5278644526500
 Content-Type: text/plain; charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable
 
 
 > +CONFIGURE_ARGS+=3D    --enable-a52
 > +CONFIGURE_ARGS+=3D       --enable-xvid
 > +CONFIGURE_ARGS+=3D    --enable-x264
 > +CONFIGURE_ARGS+=3D       --enable-libmpeg2
 > +CONFIGURE_ARGS+=3D    --enable-libmpeg2convert
 
 x264 and a52 are handled in options.mk. Both are in the default
 option set, thus enabled in a default build.
 You are right about mpeg2. (Could be made optional as well,
 but since this is needed for VCD/DVD it is too useful to be
 opted out. Also, there are no nasty licenses involved afais.)
 How about the appended patch? (I've made faac optional, although
 it will likely be needed together with x264, because the
 library cannot be redistributed on CD.)
 
 best regards
 Matthias
 
 
 ---------------------------------------------------------------------------=
 ---------------------
 ---------------------------------------------------------------------------=
 ---------------------
 Forschungszentrum Juelich GmbH
 52425 Juelich
 Sitz der Gesellschaft: Juelich
 Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
 Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
 Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
 Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
 Prof. Dr. Sebastian M. Schmidt
 ---------------------------------------------------------------------------=
 ---------------------
 ---------------------------------------------------------------------------=
 ---------------------
 
 --==_Exmh_5278644526500
 Content-Type: text/plain; name="tc.txt"; charset="us-ascii"
 Content-Description: tc.txt
 Content-Disposition: attachment; filename="tc.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/transcode/Makefile,v
 retrieving revision 1.62
 diff -u -r1.62 Makefile
 --- Makefile   18 Jan 2010 09:59:18 -0000      1.62
 +++ Makefile   6 May 2010 17:07:06 -0000
 @@ -1,7 +1,7 @@
  # $NetBSD: Makefile,v 1.62 2010/01/18 09:59:18 wiz Exp $
  
  DISTNAME=     transcode-1.1.5
 -PKGREVISION=  2
 +PKGREVISION=  3
  CATEGORIES=   multimedia
  MASTER_SITES= http://download.berlios.de/tcforge/
  EXTRACT_SUFX= .tar.bz2
 @@ -22,6 +22,9 @@
  CONFIGURE_ARGS+=      --enable-ogg
  CONFIGURE_ARGS+=      --enable-theora
  CONFIGURE_ARGS+=      --enable-vorbis
 +CONFIGURE_ARGS+=      --enable-libmpeg2
 +CONFIGURE_ARGS+=      --enable-libmpeg2convert
 +CONFIGURE_ARGS+=      --enable-xvid
  CONFIGURE_ARGS+=      --with-libavcodec-prefix=${BUILDLINK_PREFIX.ffmpeg}
  CONFIGURE_ENV+=               PATH_TO_AWK=${AWK:Q}
  
 @@ -39,7 +42,6 @@
  
  .include "options.mk"
  
 -.include "../../audio/faac/buildlink3.mk"
  .include "../../audio/lame/buildlink3.mk"
  .include "../../audio/libvorbis/buildlink3.mk"
  .include "../../converters/libiconv/buildlink3.mk"
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/transcode/options.mk,v
 retrieving revision 1.7
 diff -u -r1.7 options.mk
 --- options.mk 15 Nov 2009 18:09:35 -0000      1.7
 +++ options.mk 6 May 2010 17:07:06 -0000
 @@ -3,7 +3,7 @@
  
  PKG_OPTIONS_VAR=      PKG_OPTIONS.transcode
  PKG_SUPPORTED_OPTIONS=        a52 freetype2 mjpegtools lzo libxml2
 -PKG_SUPPORTED_OPTIONS+=       dv imagemagick x264
 +PKG_SUPPORTED_OPTIONS+=       dv imagemagick x264 faac
  
  PKG_SUGGESTED_OPTIONS=        a52 freetype2 mjpegtools libxml2
  PKG_SUGGESTED_OPTIONS+=       imagemagick x264
 @@ -78,3 +78,10 @@
  CONFIGURE_ARGS+=
  CONFIGURE_ARGS+=      --disable-x264
  .endif
 +
 +.if !empty(PKG_OPTIONS:Mfaac)
 +.  include "../../audio/faac/buildlink3.mk"
 +CONFIGURE_ARGS+=      --enable-faac
 +.else
 +CONFIGURE_ARGS+=      --disable-faac
 +.endif
 
 --==_Exmh_5278644526500--