pkg/43205: math/octave uses INSTALL_PROGRAM, not BSD_INSTALL_LIB, to install .oct libraries

[Taylor R Campbell <campbell%mumble.net@localhost>]

>Number:         43205
>Category:       pkg
>Synopsis:       math/octave uses INSTALL_PROGRAM, not BSD_INSTALL_LIB, to 
>install .oct libraries
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 24 16:35:00 +0000 2010
>Originator:     Taylor R Campbell <campbell%mumble.net@localhost>
>Release:        Mac OS X 10.5.8
>Organization:
>Environment:
System: Darwin <hostname> 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 
16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386
Architecture: i386
Machine: i386
>Description:

        The install-oct target in src/Makefile.in uses INSTALL_PROGRAM
        to install .oct libraries, but it should use BSD_INSTALL_LIB.
        Using INSTALL_PROGRAM causes the file to be stripped, which
        makes Darwin's linker unhappy.  Using BSD_INSTALL_LIB makes
        Darwin's linker happier.

>How-To-Repeat:

        Attempt to install math/octave on Darwin.  (Fix various other
        problems along the way; other PRs for those.)  Watch stripping
        failures.

>Fix:

        Apply the following patch to patches/patch-ag so that it
        changes Octave's src/Makefile.in to use BSD_INSTALL_LIB rather
        than INSTALL_PROGRAM to install .oct libraries:

Index: patches/patch-ag
===================================================================
RCS file: /cvsroot/pkgsrc/math/octave/patches/patch-ag,v
retrieving revision 1.7
diff -p -u -r1.7 patch-ag
--- patches/patch-ag    22 Dec 2009 17:46:17 -0000      1.7
+++ patches/patch-ag    24 Apr 2010 16:15:13 -0000
@@ -43,14 +43,16 @@ $NetBSD: patch-ag,v 1.7 2009/12/22 17:46
        $(INSTALL_PROGRAM) octave$(EXEEXT) 
$(DESTDIR)$(bindir)/octave-$(version)$(EXEEXT)
        cd $(DESTDIR)$(bindir) ; $(LN_S) octave-$(version)$(EXEEXT) 
octave$(EXEEXT)
  .PHONY: install-bin
-@@ -470,6 +473,7 @@ install-oct:
+@@ -470,7 +473,8 @@ install-oct:
        if [ -n "$(OCT_FILES)" ]; then \
          xfiles="$(OCT_FILES)"; \
          for f in $$xfiles; do \
+-          $(INSTALL_PROGRAM) $$f $(DESTDIR)$(octfiledir)/$$f; \
 +          ${LIBTOOL} --mode=install \
-           $(INSTALL_PROGRAM) $$f $(DESTDIR)$(octfiledir)/$$f; \
++          $(BSD_INSTALL_LIB) $$f $(DESTDIR)$(octfiledir)/$$f; \
          done; \
        fi
+ .PHONY: install-oct
 @@ -479,9 +483,8 @@ install-lib:
        $(top_srcdir)/mkinstalldirs $(DESTDIR)$(octlibdir)
        if $(STATIC_LIBS); then \