pkg/43188: nbpatch does not link on IRIX

[ginsbach%NetBSD.org@localhost]

>Number:         43188
>Category:       pkg
>Synopsis:       nbpatch does not link on IRIX
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 21 13:15:00 +0000 2010
>Originator:     Brian Ginsbach
>Release:        pkgsrc-2009Q4
>Organization:
        NetBSD
>Environment:
System: IRIX pkgtest 6.5 01080747 IP32
>Description:
The nbpatch utility fails to link on IRIX.

===> Building for nbpatch-20091021
gcc -L/usr/pkgsrc/devel/nbpatch/work/libnbcompat -Wl,-R/usr/pkg/lib  -o nbpatch 
patch.o pch.o inp.o util.o backupfile.o mkpath.o  -lnbcompat
ld32: ERROR 33: Unresolved text symbol "basename" -- 1st referenced by pch.o.
        Use linker option -v to see when and which objects, archives and dsos 
are loaded.  
ld32: ERROR 33: Unresolved text symbol "dirname" -- 1st referenced by inp.o.
        Use linker option -v to see when and which objects, archives and dsos 
are loaded.  
ld32: INFO 152: Output file removed because of error.
collect2: ld returned 2 exit status

IRIX has basename() and dirname() functions but they require linking
with an additional library (-lgen).

>How-To-Repeat:
Attempt to compile nbpatch on an IRIX system.

>Fix:
Adding LIBS.IRIX += -lgen to the Makefile fixes the problem for IRIX.