Re: pkg/43084: Fix devel/scmgit-base on big-endian

[Holger Weiss <holger%weiss.in-berlin.de@localhost>]

The following reply was made to PR pkg/43084; it has been noted by GNATS.

From: Holger Weiss <holger%weiss.in-berlin.de@localhost>
To: GNATS Bugs <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/43084: Fix devel/scmgit-base on big-endian
Date: Wed, 31 Mar 2010 01:46:42 +0200

 * Joerg Sonnenberger <joerg%britannica.bec.de@localhost> [2010-03-30 23:30]:
 >  On Tue, Mar 30, 2010 at 11:25:00PM +0000, Holger Weiss wrote:
 >  > This happens in Git versions newer than 1.6.5.2, as compat/bswap.h now
 >  > redefines htonl and ntohl to bswap32 not only on selected little-endian
 >  > platforms (as intended), but also if bswap32 has been defined in the
 >  > included system headers, which is the case at least on NetBSD.  See also
 >  > my posting to the Git list:
 >  > 
 >  > http://article.gmane.org/gmane.comp.version-control.git/143453
 > 
 >  It should use the system version if present. That often uses inline
 >  assembler for example.
 
 That may be desirable, but that's a separate issue.¹  My point is that
 Git shouldn't use bswap32 in place of htonl/ntohl on big-endian
 platforms.
 
 Holger
 
 ¹ And that's not what the Git guys intended when they introduced the
   bug I'm talking about:
 
   
http://git.kernel.org/?p=git/git.git;a=commit;h=0fcabdeb52b79775173d009ccc179db104dfbb66