pkg/42960: expat/buildlink3.mk picks up random crap from xbase

[bad%bsd.de@localhost]

>Number:         42960
>Category:       pkg
>Synopsis:       expat/buildlink3.mk picks up libexpat.so from X11BASE for 
>non-X11 program
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 11 17:20:00 +0000 2010
>Originator:     Christoph Badura
>Release:        NetBSD 5.0_STABLE base & xsrc, pkgsrc-2009Q4
>Organization:
you break it, we test it
>Environment:
System: NetBSD nervous-energy 5.0_STABLE NetBSD 5.0_STABLE (nervous-energy) 
#22: Fri Jan 29 10:40:34 UTC 2010 
root@youll-thank-me-later:/m/obj/m/src/sys/arch/i386/compile/nervous-energy i386
Architecture: i386
Machine: i386
>Description:
        
Yesterday I discovered that the binary package of subversion-base that was
compiled on a system with xsrc X11 installed fails in a X11-less domU because
of it can't load libexpat.so.1.

neon-0.29.0 requires expat, but hasn't recorded a dependency against the
expat package.  The reason for that is that the expat dependency is
satisfied through x11-links because xbase happens to be installed on the
compile machine.  However, neither neon nor expat nor any other prerequisites
for subversion-base require X11 libraries to work.

>How-To-Repeat:
        
use netbsd-5 with xsrc x11 sets installed.
set X11_TYPE=native
cd pkgsrc/www/neon && make
>Fix:
        
It is inappropriate to add x11-links for builtins when the package Makefile
does not indicate that X11 libraries are needed.

>Unformatted: