pkg/42898: math/gnumeric110 PLIST problem (missed dependency) (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         42898
>Category:       pkg
>Synopsis:       math/gnumeric110 PLIST problem (missed dependency) (+FIX)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 28 14:45:01 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386   (pkgsrc current 2010-02-28)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        math/gnumeric110 fails to produce a binary package when
        compiled in an empty sandbox (or in an empty system)
        with PKG_DEVELOPER=yes because of a PLIST problem detected
        by the file-check test.

        The problem is caused by a missing dependency on
        graphics/hicolor-icon-theme (seen this one before...)

        Most people building the package wouldn't notice, as
        graphics/hicolor-icon-theme is likely to already be installed.

>How-To-Repeat:
        I use pkg_comp with NetBSD 4.0 release sets installed
        (and libkver to get a pure appearing 4.0 release environment).
        I use X11_TYPE=modular instead of the x* sets.

        Of all of that, the only thing relevant is the use of pkg_comp
        and only because that's an easy way to achieve both an empty
        (no packages installed) environment, and PKG_DEVELOPER=yes
        all in one bang...

        Expect to see:

=> Registering installation for gnumeric-1.10.0
gnumeric-1.10.0 requires installed package GConf-2.28.0
gnumeric-1.10.0 requires installed package ORBit2-2.14.17
gnumeric-1.10.0 requires installed package desktop-file-utils-0.15
gnumeric-1.10.0 requires installed package goffice0.8-0.8.0
gnumeric-1.10.0 requires installed package gtk2+-2.18.7
gnumeric-1.10.0 requires installed package libbonobo-2.24.2
gnumeric-1.10.0 requires installed package libbonoboui-2.24.2nb1
gnumeric-1.10.0 requires installed package libglade-2.6.4nb1
gnumeric-1.10.0 requires installed package libgnomeui-2.24.2nb3
gnumeric-1.10.0 requires installed package libgsf-1.14.17
gnumeric-1.10.0 requires installed package libxml2-2.7.6
gnumeric-1.10.0 requires installed package perl-5.10.1
gnumeric-1.10.0 requires installed package py26-gobject-2.18.0
gnumeric-1.10.0 requires installed package python26-2.6.4nb4
gnumeric-1.10.0 requires installed package rarian-0.8.1
=> Checking file-check results for gnumeric-1.10.0
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkg/share/icons/hicolor/icon-theme.cache
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/math/gnumeric110
*** Error code 1

Stop.

>Fix:
        Apply the following patch to math/gnumeric110/Makefile

        I do not believe that a revbump is needed for this change.

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/math/gnumeric110/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile    18 Feb 2010 21:00:44 -0000      1.1.1.1
+++ Makefile    28 Feb 2010 14:15:45 -0000
@@ -41,6 +41,7 @@
 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../devel/libglade/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
+.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../lang/perl5/buildlink3.mk"
 .include "../../misc/goffice0.8/buildlink3.mk"
 .include "../../net/ORBit2/buildlink3.mk"