pkg/42703: time/ruby-tzinfo PLIST problem (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         42703
>Category:       pkg
>Synopsis:       time/ruby-tzinfo PLIST problem   (+FIX)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 30 09:45:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386   (pkgsrc current 2010-01-30)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        ruby-tzinfo (ruby18-tzinfo-0.3.16) contains the Olson TZ data from
        the 2010a release (so I think I saw anyway - don't trust this PR
        for that information being correct).  That version of the Olson
        tz data file added a new zone, which this package (correctly)
        installs.   However the PLIST file was not updated to account
        for the new zone file.

>How-To-Repeat:
        I use pkg_comp with NetBSD 4.0 release sets installed (etc - none
        of that is relevant for this PR).

        Upon building time/ruby-tzinfo with PKG_DEVELOPER=yes
        expect to see (something like) ...

=> Generating post-install file lists
=> Checking file-check results for ruby18-tzinfo-0.3.16
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         
/pkg_comp/obj/pkgsrc/time/ruby-tzinfo/4x/.destdir/usr/pkg/lib/ruby/gems/1.8/gems/tzinfo-0.3.16/lib/tzinfo/definitions/Asia/Novokuznetsk.rb
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/time/ruby-tzinfo

>Fix:
        Apply the patch below that corrects the missing PLIST file entry.
        The patch also does a revbump, as any binary packages built from
        time/ruby-tzinfo after it became ruby18-tzinfo-0.3.16 (without
        having PKG_DEVELOPER set) would have built a package that's missing
        this file.

        After doing that, assassinate all pkgsrc developers who do not
        have PKG_DEVELOPER=yes in their mk.conf files!   This step is a
        critcal part of the fix, and this PR should not be closed until
        it is completed....

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/time/ruby-tzinfo/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile    22 Jan 2010 15:30:32 -0000      1.11
+++ Makefile    30 Jan 2010 09:30:42 -0000
@@ -3,6 +3,7 @@
 DISTNAME=      tzinfo-0.3.16
 PKGNAME=       ${RUBY_PKGPREFIX}-${DISTNAME}
 CATEGORIES=    time
+PKGREVISION=   1
 
 MAINTAINER=    minskim%NetBSD.org@localhost
 HOMEPAGE=      http://tzinfo.rubyforge.org/
Index: PLIST
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/time/ruby-tzinfo/PLIST,v
retrieving revision 1.9
diff -u -r1.9 PLIST
--- PLIST       14 Jun 2009 18:18:00 -0000      1.9
+++ PLIST       30 Jan 2010 09:31:52 -0000
@@ -283,6 +283,7 @@
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Manila.rb
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Muscat.rb
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Nicosia.rb
+${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Novokuznetsk.rb
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Novosibirsk.rb
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Omsk.rb
 ${GEM_LIBDIR}/lib/tzinfo/definitions/Asia/Oral.rb