pkg/42671: pkgsrc-2009Q4 doesn't find xpm on NetBSD 4.0

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

>Number:         42671
>Category:       pkg
>Synopsis:       pkgsrc-2009Q4 doesn't find xpm on NetBSD 4.0
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 24 16:45:00 +0000 2010
>Originator:     Manuel Bouyer
>Release:        NetBSD 4.0.1
>Organization:
>Environment:
NetBSD/amd64 or i386 4.0.1 release
pkgsrc-2009Q4 as of 20100119
>Description:
        in pkgsrc-2009Q4 bulk builds on NetBSD 4.0.1, lots of packages
        fail to build because they can't find X11/xpm.h.
        For example see
http://nyftp.netbsd.org/pub/pkgsrc/packages/reports/2009Q4/NetBSD-4.0.1-i386/20100118.1214/xxkb-1.11/build.log
===> Building for xxkb-1.11
cc -O2 -Wall      -I/usr/pkg/include -I/usr/X11R6/include   -DCSRG_BASED   
-DFUNCPROTO=15 -DNARROWPROTO   -DAPPDEFDIR=\"/usr/pkg/lib/X11/app-defaults\" 
-DAPPDEFFILE=\"XXkb\"   -DSHAPE_EXT  -I/usr/pkg/include -I/usr/X11R6/include -c 
xxkb.c
xxkb.c: In function 'main':
xxkb.c:313: warning: pointer targets in passing argument 6 of 'XQueryTree' 
differ in signedness
xxkb.c:450: warning: pointer targets in passing argument 9 of 'XQueryPointer' 
differ in signedness
xxkb.c:670: warning: pointer targets in passing argument 6 of 'XQueryTree' 
differ in signedness
xxkb.c: In function 'GetGrandParent':
xxkb.c:954: warning: pointer targets in passing argument 6 of 'XQueryTree' 
differ in signedness
xxkb.c: In function 'GetAppWindow':
xxkb.c:974: warning: pointer targets in passing argument 6 of 'XQueryTree' 
differ in signedness
cc -O2 -Wall      -I/usr/pkg/include -I/usr/X11R6/include   -DCSRG_BASED   
-DFUNCPROTO=15 -DNARROWPROTO   -DAPPDEFDIR=\"/usr/pkg/lib/X11/app-defaults\" 
-DAPPDEFFILE=\"XXkb\"   -DSHAPE_EXT  -I/usr/pkg/include -I/usr/X11R6/include -c 
resource.c
resource.c:37:21: error: X11/xpm.h: No such file or directory
resource.c: In function 'GetElementRes':
resource.c:271: warning: pointer targets in passing argument 9 of 'XWMGeometry' 
differ in signedness
resource.c:271: warning: pointer targets in passing argument 10 of 
'XWMGeometry' differ in signedness
resource.c: In function 'LoadImage':
resource.c:473: warning: implicit declaration of function 'XpmReadFileToPixmap'
resource.c:475: error: 'XpmOpenFailed' undeclared (first use in this function)
resource.c:475: error: (Each undeclared identifier is reported only once
resource.c:475: error: for each function it appears in.)
resource.c:479: error: 'XpmFileInvalid' undeclared (first use in this function)
resource.c:483: error: 'XpmNoMemory' undeclared (first use in this function)
*** Error code 1

        Yes X11/xpm.h is there:
amd64-nb4:/>ls -l /usr/X11R6/include/X11/xpm.h
-r--r--r--  1 root  wheel  16231 Mar 11  2005 /usr/X11R6/include/X11/xpm.h

        But x11-links-0.45.4.0.1.tgz doens't link to xpm files.

>How-To-Repeat:
        Try to build a package requiring libXpm on NetBSD/i386 4.0.1 or
        NetBSD/amd64 4.0.1 (or I suspect any system where the native X11
        is Xfree).

>Fix:
        Unknown, but I wonder if pkgtools/x11-links/files/xfree.xpm
        should be renamed to xfree.libXpm ?