Re: PR/42168 CVS commit: pkgsrc/devel/scmgit-base

[Steven Drake <sdrake%xnet.co.nz@localhost>]

On Sat, 9 Jan 2010, Thomas Klausner wrote:

>  Module Name: pkgsrc
>  Committed By:        wiz
>  Date:                Sat Jan  9 15:52:19 UTC 2010
>  
>  Modified Files:
>       pkgsrc/devel/scmgit-base: Makefile
>  
>  Log Message:
>  Fix PR 42168:
>  Remove '-P' argument from cd.
>  
>  Bump PKGREVISION.
>  
>  
>  To generate a diff of this commit:
>  cvs rdiff -u -r1.16 -r1.17 pkgsrc/devel/scmgit-base/Makefile

I should point out that the above commit will change/break the behaviour 
of git shell scripts on most system's (system's were /bin/sh follows the 
ksh behaviour).

It's would be a lot better to inclose the SUBST_*.fix-cd-PD section in with
".if ${OPSYS} == ..." with the systems that need it.

From looking at the online man pages of the pkgsrc supported systems it 
looks like the systems that don't support 'cd -P' are:
NetBSD, SunOS, OSF1, HPUX, QNX and UnixWare.


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/scmgit-base/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile    9 Jan 2010 15:52:19 -0000       1.17
+++ Makefile    10 Jan 2010 06:57:03 -0000
@@ -80,6 +80,7 @@ SUBST_MESSAGE.fix-paths=Fixing hard-code
 SUBST_STAGE.fix-paths= pre-build
 SUBST_VARS.fix-paths=  PREFIX
 
+.if ${OPSYS} == "NetBSD" || ${OPSYS} == "SunOS" || ${OPSYS} == "OSF1" || 
${OPSYS} == "HPUX" || ${OPSYS} == "QNX" || ${OPSYS} == "UnixWare"
 SUBST_CLASSES+=                fix-cd-P
 SUBST_FILES.fix-cd-P=  git-sh-setup.sh
 SUBST_FILES.fix-cd-P+= t/t0000-basic.sh
@@ -88,6 +89,7 @@ SUBST_FILES.fix-cd-P+=        t/test-lib.sh
 SUBST_MESSAGE.fix-cd-P=        Fixing cd arguments.
 SUBST_STAGE.fix-cd-P=  pre-build
 SUBST_SED.fix-cd-P=    -e "s/cd -P/cd/g"
+.endif
 
 #.include "../../editors/emacs/modules.mk" # XXX TODO (see patch-ad)
 
-- 
Steven