pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/42575: x11/libxdg-basedir doesn't honor PKG_SYSCONFDIR
The following reply was made to PR pkg/42575; it has been noted by GNATS.
From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: pkg/42575: x11/libxdg-basedir doesn't honor PKG_SYSCONFDIR
Date: Sat, 09 Jan 2010 23:04:54 +0900
On Mon, 04 Jan 2010 09:10:01 +0900, <pallegra%gmail.com@localhost> wrote:
>> Description:
> Packages compiled with x11/libxdg-basedir are searching their config files
> somewhere in /etc/xdg instead of ${PKG_SYSCONFDIR}/xdg.
>
> Could you check my quick and dirty fix, and, if it's correct, commit it,
> please ?
>> How-To-Repeat:
>
>> Fix:
> It works for me...
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/x11/libxdg-basedir/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile
> --- Makefile 8 Nov 2009 18:26:15 -0000 1.1.1.1
> +++ Makefile 3 Jan 2010 23:55:26 -0000
> @@ -16,6 +16,12 @@
> USE_LIBTOOL= yes
> USE_TOOLS+= pkg-config
>+SUBST_CLASSES+= xdgetc
> +SUBST_MESSAGE.xdgetc= Fixing sysconfdir paths
> +SUBST_STAGE.xdgetc= pre-build
> +SUBST_FILES.xdgetc= src/basedir.c
> +SUBST_SED.xdgetc= -e "s,DIR_SEPARATOR_STR \"etc\",\"${PKG_SYSCONFDIR}\","
> +
> PKGCONFIG_OVERRIDE+= pkgconfig/libxdg-basedir.pc.in
> .include "../../mk/bsd.pkg.mk"
/usr/local/share for XDG_DATA_DIRS also may be replaced with ${PREFIX}/share.
From XDG Base Directory Specification:
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
"If $XDG_DATA_DIRS is either not set or empty, a value equal to
/usr/local/share/:/usr/share/ should be used."
"If $XDG_CONFIG_DIRS is either not set or empty, a value equal to /etc/xdg
should be used."
For pkgsrc which is prefered?
Replace default value with pkgsrc's one? (/etc with ${PKG_SYSCONFDIR} and
/usr/local/share with ${PREFIX}/share)
Add pkgsrc's one to default list? (${PKG_SYSCONFIDIR}:/etc for
XDG_CONDIG_DIRS and ${PREFIX}/share:/usr/local/share:/usr/share for
XDG_DATA_DIRS)
Home |
Main Index |
Thread Index |
Old Index