pkg/42506: math/R-randomForest requires fortran but doesn't say so (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         42506
>Category:       pkg
>Synopsis:       math/R-randomForest requires fortran but doesn't say so (+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 23 16:55:01 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386   (pksrc current as of 2009-12-22)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        math/R-randomForest (R-randomForest-4.5.34) includes fortran
        source but doesn't sayit needs a fortran compiler

>How-To-Repeat:
        I use pkg_comp with libkver and NetBSD 4.0 release sets installed
        (with X11_TYPE=modular instead of thye x* sets).
        Of all of that, the relevant factor here is using pkg_comp with
        an almost empty sandbox to start - most people building math/R*
        packages are going to end up with f2c (or some other) fortran
        compiler installed, and then probably never see this problem.
        I start each compile with a nearly empty sandbox, nothing installed
        (almost) beyond standard NetBSD.

        Duplicate the above environment (no fortran compiler installed)
        and attempt to build math/R-randomForest -- expect to see:

cc -std=gnu99 -I/usr/pkg/lib/R/include  -I/usr/pkg/include -I/usr/include 
-I/usr/pkg/include/freetype2    -fpic  -O2 -I/usr/pkg/include -I/usr/include 
-I/usr/pkg/include/freetype2 -c rf.c -o rf.o
f77   -fPIC  -O -c rfsub.f -o rfsub.o
PKGSRC-WARNING: Something is trying to run the fortran compiler,
PKGSRC-WARNING: but it is not added to USE_LANGUAGES in the package Makefile.
*** Error code 1

Stop.
make: stopped in /pkg_comp/obj/pkgsrc/math/R-randomForest/4x/randomForest/src
ERROR: compilation failed for package 'randomForest'
* removing '/usr/pkg/lib/R/library/randomForest'
*** Error code 1

Stop.

>Fix:
        The following patch fixed it for me,   I am fairly sure that no
        revbump is needed for this one - this is a build time only problem.

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/math/R-randomForest/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile    11 Dec 2009 19:45:46 -0000      1.2
+++ Makefile    23 Dec 2009 16:42:17 -0000
@@ -10,5 +10,7 @@
 R_PKGNAME=     randomForest
 R_PKGVER=      4.5-34
 
+USE_LANGUAGES+=        fortran
+
 .include "../../math/R/Makefile.extension"
 .include "../../mk/bsd.pkg.mk"