pkg/42355: www/drupal6 missing file renders install script unusable

[poli-mr%latenter.com.br@localhost]

>Number:         42355
>Category:       pkg
>Synopsis:       www/drupal6 missing file renders install script unusable
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 21 05:30:00 +0000 2009
>Originator:     Marco Poli
>Release:        5.0.1 pkgsrc-current
>Organization:
>Environment:
NetBSD some.server.com 5.0.1 NetBSD 5.0.1 (XEN3_DOMU) #0: Thu Jul 30 00:31:11 
UTC 2009  
builds%b7.netbsd.org@localhost:/home/builds/ab/netbsd-5-0-1-RELEASE/amd64/200907292356Z-obj/home/builds/ab/netbsd-5-0-1-RELEASE/src/sys/arch/amd64/compile/XEN3_DOMU
 amd64
>Description:
Making a pgsql install of www/drupal6, I noticed that the install script 
(available per instructions from http://localhost/drupal) would fail to 
complete the "Set up database" step even if all the data was correct, with no 
apparent error. Messing up some of the configuration data sucessfully got me 
some descriptive errors from the install script, but getting all the data 
correct would just give me nothing.

After a log search, found this in apache's error_log:

[Sat Nov 21 05:06:39 2009] [error] [client xxx.yyy.zzz.kkk] PHP Warning:  
fopen(./sites/default/default.settings.php) [<a 
href='function.fopen'>function.fopen</a>]: failed to open stream: No such file 
or directory in /usr/pkg/share/drupal/includes/install.inc on line 188, 
referer: http://some.server.com/drupal/install.php?profile=default&locale=en

Checking the /usr/pkg/share/drupal/sites/default directory I realised that the 
default.settings.php file was missing in the pkgsrc installation, and instead, 
a settings.php file was present. INSTALL.txt doc tells me that the first 
settings.php should be generated from the default.settings.php file, but says 
nothing about erasing the default.settings.php file.
>How-To-Repeat:
echo "PKG_OPTIONS.drupal+=pgsql" >> /etc/mk.conf
cd /usr/pkgsrc/www/drupal6
make install
echo "Include /usr/pkg/etc/drupal.conf >> /usr/pkg/etc/httpd/httpd.conf"
Launch a web browser and point to http://localhost/drupal
Get to the "Set up database" part and put in the correct database connection 
data.
>Fix:
cp /usr/pkg/share/drupal/sites/default/settings.php 
/usr/pkg/share/drupal/sites/default/default.settings.php

But the real fix should be not deleting the default.settings.php file during 
the install procedure.