pkg/42276: ntp4 still does not honour SYSCONFDIR

[jsl%apache.org@localhost]

>Number:         42276
>Category:       pkg
>Synopsis:       ntp4 still does not honour SYSCONFDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 06 08:25:00 +0000 2009
>Originator:     Jason Lingohr
>Release:        Linux 2.4.31
>Organization:
>Environment:
Linux fully 2.4.31 #7 Wed Jul 20 16:40:54 EST 2005 i686 i686 i386 GNU/Linux

>Description:
As per ntp bug 382 (https://support.ntp.org/bugs/show_bug.cgi?id=382), the 
latest ntp4 (4.2.4p7) still has this issue.

I suggest as a workaround, supplying the config file path on the commandline 
via the rc script.

>How-To-Repeat:
Run it.  Marvel at how it has been compiled to expect the conf file in 
/usr/pkg/etc when in fact a strings of the binary shows otherwise.
>Fix:
--- /usr/pkg/share/examples/rc.d/ntpd   2009-11-06 19:10:25.000000000 +1100
+++ rc.d/ntpd   2009-11-06 19:16:14.000000000 +1100
@@ -10,12 +10,15 @@

 . /etc/rc.subr

+: ${ntpd_conf:=/usr/pkg/etc/ntp.conf}
+
 name="ntpd"
 rcvar=$name
 command="/usr/pkg/bin/${name}"
 pidfile="/var/run/${name}.pid"
 start_precmd="ntpd_precmd"
-required_files="/usr/pkg/etc/ntp.conf"
+required_files="${ntpd_conf}"
+command_args="-c ${ntpd_conf}"

 ntpd_precmd()
 {