pkg/41964: multimedia/ffmpeg compilation fails, NetBSD 4.0 / i386

[kre%munnari.OZ.AU@localhost]

>Number:         41964
>Category:       pkg
>Synopsis:       multimedia/ffmpeg compilation fails, NetBSD 4.0 / i386
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 01 02:15:00 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0/i386   pkgsrc -current
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        The compilation flags change in ffmpeg-20090611nb2 breaks compilation
        on i386 (on NetBSD 4.0 at least).

>How-To-Repeat:
        I use pkg_comp with libkver and NetBSD 4.0 release sets installed
        (except x*, but that's irrelevant here) to get a fairly pure
        NetBSD 4.0 release environment.

        With that setup, building ffmpeg-20090611nb2 (multimedia/ffmpeg)
        produces ...

cc -DHAVE_AV_CONFIG_H -I. 
-I"/pkg_comp/obj/pkgsrc/multimedia/ffmpeg/4x/ffmpeg-export-2009-06-11" -O2 
-I/usr/pkg/include -I/usr/include -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 
-std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fomit-frame-pointer 
-pthread -Wdeclaration-after-statement -Wall -Wno-switch 
-Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign 
-Wcast-qual -Wwrite-strings -Wundef -O3 -fno-math-errno         -fPIC -DPIC -c 
-o libavcodec/h264.o libavcodec/h264.c
libavcodec/h264.c: In function 'pred_direct_motion':
libavcodec/h264.c:1048: warning: assignment from incompatible pointer type
libavcodec/h264.c:1049: warning: assignment from incompatible pointer type
libavcodec/h264.c: In function 'filter_mb_fast':
libavcodec/h264.c:6289: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
libavcodec/h264.c: In function 'filter_mb_dir':
libavcodec/h264.c:6346: warning: initialization from incompatible pointer type
libavcodec/h264.c:6347: warning: initialization from incompatible pointer type
In file included from libavcodec/h264.c:8184:
libavcodec/svq3.c: In function 'svq3_decode_slice_header':
libavcodec/svq3.c:721: warning: cast discards qualifiers from pointer target 
type
libavcodec/svq3.c:724: warning: cast discards qualifiers from pointer target 
type
libavcodec/svq3.c: In function 'svq3_decode_init':
libavcodec/svq3.c:870: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
libavcodec/cabac.h: In function 'get_cabac_noinline':
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h: In function 'decode_cabac_residual_nondc':
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/x86/h264_i386.h:97: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/x86/h264_i386.h:44: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h: In function 'decode_cabac_residual_dc':
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/x86/h264_i386.h:97: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/x86/h264_i386.h:44: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h: In function 'decode_cabac_mb_mvd':
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h: In function 'decode_mb_cabac':
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
libavcodec/cabac.h:527: error: PIC register '%ebx' clobbered in 'asm'
gmake: *** [libavcodec/h264.o] Error 1
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/multimedia/ffmpeg
*** Error code 1

Stop.

>Fix:
        As I understand it, the change from ffmpeg-20090611nb1 (which
        worked in this same environment) to ffmpeg-20090611nb2 was to
        correct the build on a different architecture - that suggests
        that the changes should be made conditional upon architecture
        rather than general.