pkg/41907: multimedia/dvdstyler needs textproc/xmlto and archivers/zip

[kre%munnari.OZ.AU@localhost]

>Number:         41907
>Category:       pkg
>Synopsis:       multimedia/dvdstyler needs textproc/xmlto and archivers/zip
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 19 03:20:00 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0_STABLE
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        As the subject says, xmlto is (apparently) required, but nothing
        ensures that it is present - for multimedia/dvdstyler

>How-To-Repeat:
        Attempt to build multimedia/dvdstyler on a system without textproc/xmlto
        installed.   I use a pkg_comp arena, with libkver and NetBSD 4.0
        sets installed (execept x* - I use pkgsrc modular xorg instead,
        but that's irrelevant to this problem) which helps produce an environ
        with as few dependencies installed as is (almost) possible to start..

        With that setup, expect to see ..

checking for xmlto... no
configure: error:
    DVDStyler requires xmlto to build DocBook documentation.
    Please check that xmlto is in path.

*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/multimedia/dvdstyler

        After correcting that, see the exact same thing with zip ...

checking for xmlto... /usr/pkg/bin/xmlto
checking for zip... no
configure: error:
    DVDStyler requires zip to build html help file.
    Please check that zip is in path.

*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/multimedia/dvdstyler

>Fix:
        Add dependencies upon xmlto and zip - perhaps something like
        the patch below (which seems to work - at least as far
        as allowing the config stage to succeed - it is still
        compiling as I send this).

--- Makefile.was        2009-08-18 15:45:18.000000000 +0700
+++ Makefile    2009-08-19 10:15:30.000000000 +0700
@@ -15,6 +15,8 @@
 DEPENDS+=      dvdauthor>=0.6.10:../../multimedia/dvdauthor
 DEPENDS+=      dvd+rw-tools-[0-9]*:../../sysutils/dvd+rw-tools
 DEPENDS+=      mpgtx-[0-9]*:../../graphics/mpgtx
+DEPENDS+=      xmlto-[0-9]*:../../textproc/xmlto
+DEPENDS+=      zip-[0-9]*:../../archivers/zip
 
 USE_LANGUAGES=         c c++
 USE_PKGLOCALEDIR=      yes