pkg/41782: ./bootstraping in unprivileged mode passed but installing net/tnftp failed

[maxfalcon%yandex.ru@localhost]

>Number:         41782
>Category:       pkg
>Synopsis:       ./bootstraping in unprivileged mode passed but installing 
>net/tnftp failed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 25 17:55:00 +0000 2009
>Originator:     Maxim Falcony
>Release:        pkgsrc on Linux
>Organization:
>Environment:
Linux falcon 2.6.30-ARCH #1 SMP PREEMPT Mon Jul 20 11:20:32 UTC 2009 i686 
Intel(R) Pentium(R) M processor 1.80GHz GenuineIntel GNU/Linux
>Description:
if after
cd ~/pkgsrc/bootstrap ; ./bootstrap --unprivileged

I trying to install any package then it fetch tnftp and building it but failed. 
Reason that source code of tnftp contain function which named "getline". This 
name conflicts with same function name in Linux /usr/include/stdio.h    








>How-To-Repeat:

/home/falcon/pkgsrc/net/tnftp ; bmake install clean
bash: /home/falcon/pkgsrc/net/tnftp: 
является 
директорией
=> Bootstrap dependency digest>=20010302: found digest-20080510
=> Bootstrap dependency tnftp-[0-9]*: NOT found
=> Verifying reinstall for ../../net/tnftp
===> Skipping vulnerability checks.
WARNING: No /home/falcon/pkg/var/db/pkg/pkg-vulnerabilities file found.
WARNING: To fix run: `/home/falcon/pkg/sbin/pkg_admin -K 
/home/falcon/pkg/var/db/pkg fetch-pkg-vulnerabilities'.
===> Building for tnftp-20070806
( cd libedit; /home/falcon/pkg/bin/bmake )
( cd libnetbsd; /home/falcon/pkg/bin/bmake )
( cd src; /home/falcon/pkg/bin/bmake )
gcc -Wno-error -I/usr/include -I. -I./.. -I. -I.. -I./../libedit  
-I./../libnetbsd -I/usr/include -c cmds.c
In file included from ftp_var.h:122,
                 from cmds.c:131:
extern.h:138: error: conflicting types for 'getline'
/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
*** Error code 1

Stop.
bmake: stopped in /home/falcon/pkgsrc/net/tnftp/work/tnftp-20070806/src
*** Error code 1

Stop.
bmake: stopped in /home/falcon/pkgsrc/net/tnftp/work/tnftp-20070806
*** Error code 1

Stop.
bmake: stopped in /home/falcon/pkgsrc/net/tnftp
*** Error code 1
>Fix:
Just rename this function 

cd pkgsrc/net/tnftp/files/
sed -i   "s|getline|ftp_getline|g"  src/cmds.c
sed -i   "s|getline|ftp_getline|g"  src/extern.h
sed -i   "s|getline|ftp_getline|g"  src/fetch.c
sed -i   "s|getline|ftp_getline|g"  src/main.c
sed -i   "s|getline|ftp_getline|g"  src/util.c
cd pkgsrc/net/tnftp ; bmake install clean clean-depends