pkg/41521: squid 3.1 pid file is not where we expect it

[Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost>]

>Number:         41521
>Category:       pkg
>Synopsis:       squid 3.1 pid file is not where we expect it
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 01 20:50:00 +0000 2009
>Originator:     Hauke Fath
>Release:        NetBSD 4.0_STABLE
>Organization:
Falling Raindrops
>Environment:
        
        
System: NetBSD pizza.causeuse.org 4.0_STABLE NetBSD 4.0_STABLE (PIZZA_PF) #0: 
Sun May 3 16:52:31 CEST 2009 
hauke%pizza.causeuse.org@localhost:/var/obj/netbsd-builds/4/sparc/sys/arch/sparc/compile/PIZZA_PF
 sparc
Architecture: sparc
Machine: sparc
>Description:

        The www/squid31 (probably other versions, too) package puts
        its pid file at /var/squid/logs/squid.pid whereas the squid
        rc.d script - and probably also hier(7) - expects it at
        /var/run/squid.pid.

# ps axc | grep squid
 6298 ?     IWs    0:00.07 squid
11134 ?     S    102:28.54 squid
# /etc/rc.d/squid status
squid is not running.
# grep pid /etc/rc.d/squid
/etc/rc.d/squid:pidfile="/var/run/${name}.pid"
/etc/rc.d/squid:        if [ -f ${pidfile} ] ; then
/etc/rc.d/squid:                DAEMON_PID=`sed 1q ${pidfile}`
/etc/rc.d/squid:                if [ -f ${pidfile} ] ; then
/etc/rc.d/squid:                if [ -f ${pidfile} ] ; then
# ls -l /var/squid/logs
total 84
-rw-r-----  1 squid  squid  82325 Jun  1 22:01 netdb.state
-rw-r--r--  1 root   squid      6 May 15 08:22 squid.pid
# 

The netdb.state should probably be in /var/run, too.
  

>How-To-Repeat:

        Install squid31, /etc/rc.d/squid restart and be surprised.

        Looking in /usr/pkg/share/examples/squid/squid.conf, you'll
        find

#  TAG: pid_filename
#       A filename to write the process-id to.  To disable, enter "none".
#
#Default:
# pid_filename /var/squid/logs/squid.pid


>Fix:

        Configure with $VARBASE/run as default pid_filename.

>Unformatted: