pkg/41422: 'make depends DEPENDS=do-bin-install' vs. 'pkg_add -A'

[cheusov%tut.by@localhost]

>Number:         41422
>Category:       pkg
>Synopsis:       'make depends DEPENDS=do-bin-install' vs. 'pkg_add -A'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 13 07:40:00 +0000 2009
>Originator:     Aleksey Cheusov
>Release:        linux
>Organization:
home
>Environment:
linux
>Description:
The following command
   make depends DEPENDS=do-bin-install
do not set "installed as a dependency" flag to the installed packages.
This is because -A flag is not passed to the underlying 'pkg_add'.

I think the following patch should be applied but it alone doesn't solve the 
problem.

>How-To-Repeat:

>Fix:
Index: mk/bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1956
diff -u -r1.1956 bsd.pkg.mk
--- mk/bsd.pkg.mk       9 Apr 2009 00:51:23 -0000       1.1956
+++ mk/bsd.pkg.mk       13 May 2009 07:29:04 -0000
@@ -651,7 +651,7 @@
 PKG_ARGS_ADD=          -W ${LOCALBASE} -w ${DEFAULT_VIEW}
 .endif
 _BIN_INSTALL_FLAGS=    ${BIN_INSTALL_FLAGS}
-.if defined(_AUTOMATIC) && !empty(_AUTOMATIC:MYES)
+.if defined(_AUTOMATIC) && !empty(_AUTOMATIC:M[Yy][Ee][Ss])
 _BIN_INSTALL_FLAGS+=   -A
 .endif
 _BIN_INSTALL_FLAGS+=   ${PKG_ARGS_ADD}