Re: pkg/41170: pkgsrc/x11/xplanet build fails on solaris (patch included)

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/41170; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/41170: pkgsrc/x11/xplanet build fails on solaris (patch
        included)
Date: Wed, 8 Apr 2009 23:27:18 +0200

 On Wed, Apr 08, 2009 at 04:10:05PM +0000, Tim Zingelman wrote:
 >  After more research, it appears that the main use of signbit() is to
 >  detect the difference between 0.0 and -0.0 so the simple < 0 check
 >  fails to do what is needed.
 
 It is used in one place and I think that place actually using it
 incorrectly:
 
 return signbit(dp1) == signbit(dp2) || fabs(dp1) < 1e-10;
 
 should be something like:
 return fabs(dp1) < 1e-10 || fabs(dp2) < 1e-10 ||
 (dp1 > 0.0 && dp2 > 0.0) || (dp1 < 0.0 && dp2 < 0.0);
 
 Joerg