pkg/41090: Obselete patch in pkgsrc-current causes x11/dmenu not to work from within wm/wmii

[bughunting%xs4all.nl@localhost]

>Number:         41090
>Category:       pkg
>Synopsis:       Obselete patch in pkgsrc-current causes x11/dmenu not to work 
>from within wm/wmii
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 28 20:30:00 +0000 2009
>Originator:     Bug Hunting
>Release:        N/A
>Organization:
>Environment:
N/A
>Description:
In pkgsrc(-current), wm/wmii contains a patch which is not useful when a 
version of x11/dmenu higher then 3.6 is being used.  In fact, the patch
prevents dmenu from running when being called from within wmii, since an
obselete option (`-y -0') of dmenu is being called.

The options `-x', `-y' and `-w' were removed between version 3.6 and 3.7
of wmii; `-b' was added in place (changelog on
<http://code.suckless.org/hg/dmenu/log/0508a3a6ee10>).  The
pkgsrc/wm/wmii/patches/patch-ad patch causes wmii to use the old dmenu
syntax, which breaks when a dmenu version higher then 3.6 is being used.
>How-To-Repeat:
Install wm/wmii (at the time of writing at version 3.6nb3) with a version
of x11/dmenu higher then 3.6 (at the time of writing, and also the version
with which this problem was discovered, dmenu-3.9).  Then, call dmenu
from within wmii with, for example, `MODKEY-p', `MODKEY-a', or MODKEY-t'.
The dmenu menu will not appear.
>Fix:
Proposed solution:
1. Remove pkgsrc/wm/wmii/patches/patch-ad;
2. apply the following patch.

$ cd /usr/pkgsrc/wm/wmii; cvs diff -u Makefile
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/wm/wmii/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile    5 Mar 2009 09:20:57 -0000       1.19
+++ Makefile    28 Mar 2009 20:14:38 -0000
@@ -9,7 +9,7 @@
 HOMEPAGE=              http://wmii.suckless.org/
 COMMENT=               Modular and keyboard-friendly window manager
 
-DEPENDS+=              dmenu>=3.6:../../x11/dmenu
+DEPENDS+=              dmenu>=3.7:../../x11/dmenu
 
 USE_TOOLS+=            tbl