pkg/40584: audio/faad2 is not configured/installed with libmp4ff

[raymond.meyer%rambler.ru@localhost]

>Number:         40584
>Category:       pkg
>Synopsis:       audio/faad2 is not configured/installed with libmp4ff
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 08 20:55:00 +0000 2009
>Originator:     RM
>Release:        
>Organization:
>Environment:
NetBSD ultra10 5.0_BETA NetBSD 5.0_BETA (GENERIC) #0: Tue Feb  3 21:25:22 GMT 
2009  root@p3smp:/opt/obj.sparc64/sys/arch/sparc64/compile/GENERIC sparc64
>Description:
audio/faad2 includes libmp4ff, however by default it is not installed. Maybe 
libmp4ff API is not stable yet, so the faad2 developers disabled it in the 
Makefile. The problem is some software uses libmp4ff for reading .mp4 files. 
For example audio/musicpd looks for libmp4ff during configure stage in order to 
enable .mp4 music file support. All my music files are encoded into .mp4 
format, so without libmp4ff I can't use musicpd to play them.

I think pkgsrc should patch faad2 Makefiles in order to build and install 
libmp4ff.
>How-To-Repeat:

>Fix:
Edit common/mp4ff/Makefile.am and replace line

noinst_LTLIBRARIES = libmp4ff.la

with

lib_LTLIBRARIES = libmp4ff.la
include_HEADERS = mp4ff.h

Edit common/mp4ff/mp4ff.h and replace line

#include "mp4ff_int_types.h"

with

#if HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#if HAVE_INTTYPES_H
#include <inttypes.h>
#endif
#if HAVE_STDINT_H
#include <stdint.h>
#endif

Finally change audio/faad2/PLIST to contain the following list of files

@comment $NetBSD$
bin/faad
include/faad2/faad.h
include/faad2/faad2-config.h
include/faad2/mp4ff.h
include/faad2/neaacdec.h
lib/libfaad.la
lib/libmp4ff.la
@dirrm include/faad2