pkg/40515: cdpack has problems when mk.conf has "PKG_SUFX= .tbz"

[jfisher4%cinci.rr.com@localhost]

>Number:         40515
>Category:       pkg
>Synopsis:       cdpack has problems when mk.conf has "PKG_SUFX= .tbz"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 29 18:15:00 +0000 2009
>Originator:     John fisher
>Release:        NetBSD current as of 20081020
>Organization:
>Environment:
NetBSD rterm.rse.com 4.99.73 NetBSD 4.99.73 (GENERIC_JDF) #0: Tue Oct 21 
09:07:54 EDT 2008  
root%rterm.rse.com@localhost:/usr/INSTALL-current-20080908/NetBSD-current-20081020/src/sys/arch/i386/compile/GENERIC_JDF
 i386

>Description:
cdpack hard codes tgz suffix which causes problems if you build packages with 
"PKG_SUFX= .tbz" set in mk.conf.  Below shows that the package jpilot-syncmal 
link name gets the added extention of .tgz to it, and the link points to the 
file jpilot-syncmal-0.80.tbz.tgz which does not exists, jpilot-syncmal-0.80.tbz 
does though (also show below).  This produces warning messages of "WARNING:  
binary package "jpilot-syncmal-0.80.tbz" has zero size".

disk1/packages/All>ls -al jpilot-syncmal*
lrwxr-xr-x  1 root  wheel  52 Jan 29 11:51 jpilot-syncmal-0.80.tbz.tgz@ -> 
/usr/pkgsrc/packages/All/jpilot-syncmal-0.80.tbz.tgz

disk1/packages/All>ls -al /usr/pkgsrc/packages/All/jpilot-syncmal*
-rw-r--r--  1 root  wheel  11561 Jan 24 10:27 
/usr/pkgsrc/packages/All/jpilot-syncmal-0.80.tbz

>How-To-Repeat:
add/change in mk.conf PKG_SUFX= .tbz
compile several packages in /usr/pkgsrc
I created a common directory with some added files (not really needed to see 
the problem)
I ran: cdpack -dvd -ac -af -X /common /usr/pkgsrc/packages/All /dvdimages

>Fix:
Suggestion:
Have cdpack check in mk.conf for PKG_SUFX and pass what it is set to to 
basename for the suffix instead of tgz.