Re: pkg/39715: bmake: bug in bsd.files.mk ?

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR pkg/39715; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/39715: bmake: bug in bsd.files.mk ?
Date: Wed, 08 Oct 2008 23:52:01 +0300

 --=-=-=
 
 I've found the following in bsd.files.mk
 
    # This file can be included multiple times.  It clears the definition of
    # FILES at the end so that this is possible.
    ...
    FILES:=
 
 Why this behaviour is bad?
 
 1) It breaks use of FILES variable in user's Makefiles.
 2) It breaks compatibility with other *BSD/makes/mk script, e.g.
     FreeBSD make.
 
 I propose the following patch
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: inline; filename=bsd.files.mk.patch
 Content-Description: patch
 
 Index: files/bsd.files.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/bootstrap-mk-files/files/bsd.files.mk,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 bsd.files.mk
 --- files/bsd.files.mk 14 Jul 2006 23:13:00 -0000      1.1.1.1
 +++ files/bsd.files.mk 8 Oct 2008 20:48:43 -0000
 @@ -3,6 +3,9 @@
  # This file can be included multiple times.  It clears the definition of
  # FILES at the end so that this is possible.
  
 +.if !defined(_BSD_FILES_MK)
 +_BSD_FILES_MK:=       1
 +
  .PHONY:               filesinstall
  realinstall:  filesinstall
  
 @@ -37,4 +40,4 @@
  filesinstall::
  .endif
  
 -FILES:=
 +.endif # _BSD_FILES_MK
 
 --=-=-=
 
 
 -- 
 Best regards, Aleksey Cheusov.
 
 --=-=-=--