Re: pkg/39628: pkgtools/pkg_install fails due to unresolved 'shquote' symbol on IRIX

["Stuart Shelton" <srcshelton%gmail.com@localhost>]

With those patches, libnbcompat and libfetch build correctly, but
pkginstall fails with:

cc-1199 cc: WARNING File = show.c, Line = 386
  The indicated format string conversion is invalid.

            printf("FILE_SIZE=%" MY_PRIu64 "\n", (uint64_t)st.st_size);
                                 ^

cc-1018 cc: ERROR File = show.c, Line = 386
  An unmatched left parentheses "(" appears in an expression.

            printf("FILE_SIZE=%" MY_PRIu64 "\n", (uint64_t)st.st_size);
                                 ^

1 error detected in the compilation of "show.c".
*** Error code 2

Stop.
bmake: stopped in
/usr/bsd/var/tmp/pkgtools/pkg_install/work/pkg_install-20080916/info
*** Error code 1

Stop.
bmake: stopped in
/usr/bsd/var/tmp/pkgtools/pkg_install/work/pkg_install-20080916
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/pkg_install
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/pkg_install


Other warnings reported include a fair number of 'function implicitly
defined' warnings (which I can report if there's interest in including
all of the necessary header files) and the following:

cc-1164 cc: WARNING File = sha2hl.c, Line = 92
  Argument of type "char *" is incompatible with parameter of type
          "unsigned char *".

        return (num < 0 ? 0 : SHA256_End(&ctx, buf));
                                               ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 119
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1515 cc: WARNING File = sha2hl.c, Line = 166
  A value of type "char *" cannot be assigned to an entity of type
          "unsigned char *".

        if ((ret = buffer) != NULL) {
                 ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 179
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1515 cc: WARNING File = sha2hl.c, Line = 226
  A value of type "char *" cannot be assigned to an entity of type
          "unsigned char *".

        if ((ret = buffer) != NULL) {
                 ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 239
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1047 cc: WARNING File =
libarchive/archive_read_support_format_ar.c, Line = 75
  Macro "isdigit" (declared at line 113 of "/usr/include/internal/ctype_core.h")
          has an incompatible redefinition.

  #define isdigit(x)    (x) >= '0' && (x) <= '9'
          ^

cc-3201 cc: REMARK File = file.c, Line = 76
  The parameter "flags" was never referenced.

  fetchXGetFile(struct url *u, struct url_stat *us, const char *flags)
                                                                ^

cc-3201 cc: REMARK File = file.c, Line = 191
  The parameter "flags" was never referenced.

  fetchStatFile(struct url *u, struct url_stat *us, const char *flags)
                                                                ^

cc-3201 cc: REMARK File = file.c, Line = 216
  The parameter "flags" was never referenced.

  fetchListFile(struct url_list *ue, struct url *u, const char
*pattern, const char *flags)

              ^

cc-3969 cc: REMARK File = ftp.c, Line = 728
  explicit conversion of a 64-bit integral type to a smaller integral type
          (potential portability problem)

                        if (ftp_cmd(conn, "REST %lu", (unsigned
long)offset) != FTP_FILE_OK)
                                                      ^

cc-3201 cc: REMARK File = http.c, Line = 1145
  The parameter "URL" was never referenced.

  fetchPutHTTP(struct url *URL, const char *flags)
                           ^

cc-3201 cc: REMARK File = http.c, Line = 1145
  The parameter "flags" was never referenced.

  fetchPutHTTP(struct url *URL, const char *flags)
                                            ^

cc-3604 cc: WARNING File = http.c, Line = 1321
  missing return statement at end of non-void function "parse_index"

  }
  ^

cc-3201 cc: REMARK File = http.c, Line = 1327
  The parameter "pattern" was never referenced.

  fetchListHTTP(struct url_list *ue, struct url *url, const char
*pattern, const char *flags)
                                                                  ^

cc-1188 cc: WARNING File = fexec.c, Line = 85
  The indicated type qualifier is meaningless on cast type.

                (void)execvp(file, (char ** const)argv);
                                    ^

cc-3604 cc: WARNING File = iterate.c, Line = 402
  missing return statement at end of non-void function "match_best_file"

  }
  ^



2008/9/25 Joerg Sonnenberger <joerg%britannica.bec.de@localhost>:
> The following reply was made to PR pkg/39628; it has been noted by GNATS.
>
> From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc:
> Subject: Re: pkg/39628: pkgtools/pkg_install fails due to unresolved
>        'shquote' symbol on IRIX
> Date: Thu, 25 Sep 2008 16:53:13 +0200
>
>  On Thu, Sep 25, 2008 at 12:15:01PM +0000, srcshelton%gmail.com@localhost 
> wrote:
>  > Is this symbol missing from nbcompat?
>
>  [note: this is the pkg_install-renovation branch]
>
>  Yes, the compat code is not (yet) commited. You can find the pending
>  patches on http://www.netbsd.org/~joerg/nbcompat.diff and
>  http://www.netbsd.org/~joerg/libfetch.diff
>
>  Joerg
>
>