pkg/39386: www/squid does not support LDAP authentication

[ef%math.uni-bonn.de@localhost]

>Number:         39386
>Category:       pkg
>Synopsis:       www/squid does not support LDAP authentication
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 20 10:10:00 +0000 2008
>Originator:     Edgar Fuß
>Release:        2008Q1
>Organization:
Mathematisches Institut der Uni Bonn, Computerabteilung
>Environment:
>Description:
There is no SQUID_BASIC_AUTH_HEPERS setting for www/squid to correctly build 
with LDAP authentication
>How-To-Repeat:
cd www/squid
SQUID_BASIC_AUTH_HELPERS="getpwnam MSNT NCSA YP LDAP" make build

>Fix:
Is the following patch OK or should there be a pkgsrc option for it a la 
pam-helper?

--- Makefile.orig       2008-04-10 11:38:23.000000000 +0200
+++ Makefile    2008-06-04 11:29:16.000000000 +0200
@@ -58,12 +58,13 @@
 OPTIONAL_FILES+= bin/cossdump libexec/diskd-daemon libexec/dnsserver
 OPTIONAL_FILES+= libexec/pinger libexec/unlinkd
 #
-# basic auth helpers (except LDAP, multi-domain-NTLM and SASL)
+# basic auth helpers (except multi-domain-NTLM and SASL)
 #
 OPTIONAL_FILES+= libexec/getpwname_auth libexec/msnt_auth libexec/ncsa_auth
 OPTIONAL_FILES+= libexec/pam_auth ${PKGMANDIR}/man8/ncsa_auth.8
 OPTIONAL_FILES+= ${PKGMANDIR}/man8/pam_auth.8
 OPTIONAL_FILES+= libexec/smb_auth libexec/yp_auth libexec/wb_auth
+OPTIONAL_FILES+= libexec/squid_ldap_auth ${PKGMANDIR}/man8/squid_ldap_auth.8
 #
 # digest auth helpers
 #
--- options.mk.orig     2007-08-02 17:45:10.000000000 +0200
+++ options.mk  2008-06-04 11:31:13.000000000 +0200
@@ -111,6 +111,9 @@
 .endif
 
 .if !empty(SQUID_BASIC_AUTH_HELPERS)
+.if !empty(SQUID_BASIC_AUTH_HELPERS:MLDAP)
+.include "../../databases/openldap-client/buildlink3.mk"
+.endif
 CONFIGURE_ARGS+= --enable-basic-auth-helpers=${SQUID_BASIC_AUTH_HELPERS:Q}
 .endif