pkg/39238: pkgsrc bootstrap fails on OpenSolaris 2008.05 during install phase

["David H. Gutteridge" <dhgutteridge%sympatico.ca@localhost>]

>Number:         39238
>Category:       pkg
>Synopsis:       pkgsrc bootstrap fails on OpenSolaris 2008.05 during install
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 28 08:05:00 +0000 2008
>Originator:     David H. Gutteridge
>Release:        OpenSolaris 2008.05
>Organization:
>Environment:


System: SunOS arcus-opensolaris 5.11 snv_86 i86pc i386 i86pc Solaris
Architecture: i386
Machine: i386
>Description:
When trying to bootstrap pkgsrc on OpenSolaris 2008.05 I'm encountering
the following issue:

===> Installing packages
===> running: (cd /export/home/disciple/pkgsrc/pkgtools/bootstrap-mk-files 
&& /export/home/disciple/pkgsrc/bootstrap/work/bin/bmake  -DPKG_PRESERVE 
MAKECONF=/export/home/disciple/pkgsrc/bootstrap/work/mk.conf install)
pdksh: /usr/ucb/echo: not found
bmake: "../../mk/compiler/../../mk/compiler/gcc.mk" line 96: warning: "if 
/export/home/disciple/pkgsrc/bootstrap/work/sbin/pkg_admin -K 
/export/home/disciple/pkg/var/db/pkg pmatch 'gcc>=2.8.0' gcc-2.8.0 
2>/dev/null; then  /usr/ucb/echo "YES";                                      
          else                                                            
/usr/ucb/echo "NO";                                             fi" returned 
non-zero status
pdksh: /usr/ucb/echo: not found
bmake: "../../mk/compiler/../../mk/compiler/gcc.mk" line 258: warning: "if 
/export/home/disciple/pkgsrc/bootstrap/work/sbin/pkg_admin -K 
/export/home/disciple/pkg/var/db/pkg pmatch 'gcc>=none' gcc-3.4.3 
2>/dev/null; then  /usr/ucb/echo "NO";                                       
          else                                                            
/usr/ucb/echo "YES";                                            fi" returned 
non-zero status
pdksh: /usr/ucb/echo: not found
bmake: "../../mk/compiler/../../mk/compiler/gcc.mk" line 272: warning: "if 
/export/home/disciple/pkgsrc/bootstrap/work/sbin/pkg_admin -K 
/export/home/disciple/pkg/var/db/pkg pmatch 'gcc3-c>=none' gcc3-c-3.4.6 
2>/dev/null; then  /usr/ucb/echo "NO";                                       
    else                                                            
/usr/ucb/echo "YES";                                            fi" returned 
non-zero status
pdksh: /usr/ucb/echo: not found
bmake: 
"path=/export/home/disciple/pkg/bin:/export/home/disciple/pkg/sbin:/usr/xpg4/bin::/usr/gnu/bin:/usr/bin:/usr/X11/bin:/usr/sbin:/sbin:/sbin:/usr/sbin:/usr/ccs/bin;
 
                                                for i in 
/export/home/disciple/pkg/bin 
/export/home/disciple/pkgsrc/bootstrap/work/wrk/pkgtools/bootstrap-mk-files/work/.tools/bin
 
/export/home/disciple/pkgsrc/bootstrap/work/wrk/pkgtools/bootstrap-mk-files/work/.buildlink/bin
 
/export/home/disciple/pkgsrc/bootstrap/work/wrk/pkgtools/bootstrap-mk-files/work/.wrapper/bin;
 
do path="$i:$path"; done;             /usr/ucb/echo "$path"" returned 
non-zero status
/export/home/disciple/pkgsrc/bootstrap/work/bin/pdksh: 
/export/home/disciple/pkg/sbin/audit-packages: not found
/export/home/disciple/pkgsrc/bootstrap/work/bin/pdksh: /usr/ucb/echo: not 
found
/export/home/disciple/pkgsrc/bootstrap/work/bin/pdksh: /usr/ucb/echo: not 
found
/export/home/disciple/pkgsrc/bootstrap/work/bin/pdksh: /usr/ucb/echo: not 
found
/export/home/disciple/pkgsrc/bootstrap/work/bin/pdksh: /usr/ucb/echo: not 
found
*** Error code 127

Stop.
bmake: stopped in /export/home/disciple/pkgsrc/pkgtools/bootstrap-mk-files
===> exited with status 1
aborted.


>How-To-Repeat:
(As above.)

>Fix:
In pkgsrc/mk/tools/tools.SunOS.mk there's a hard-coded assumption that
/usr/ucb/echo exists.  On OpenSolaris 2008.05 it does not (with a stock
install).  There are equivalent commands available as /usr/bin/echo and
/usr/gnu/bin/echo.

Also, there's an assumption that /usr/ucb/install exists, it likewise
does not on OpenSolaris 2008.05 (again, with a stock install).
/usr/bin/ginstall seems like the best fit instead.

--- tools.SunOS.mk~     2007-11-28 20:07:50.000000000 -0500
+++ tools.SunOS.mk      2008-07-28 02:06:24.046214227 -0400
@@ -38,7 +38,11 @@
TOOLS_PLATFORM.diff3?=         /usr/bin/diff3
.endif
TOOLS_PLATFORM.dirname?=       /usr/bin/dirname
+.if exists(/usr/ucb/echo)
TOOLS_PLATFORM.echo?=          /usr/ucb/echo
+.elif exists(/usr/bin/echo)
+TOOLS_PLATFORM.echo?=          /usr/bin/echo
+.endif
TOOLS_PLATFORM.egrep?=         /usr/xpg4/bin/grep -E
TOOLS_PLATFORM.env?=           /usr/bin/env
TOOLS_PLATFORM.expr?=          /usr/xpg4/bin/expr
@@ -55,7 +59,11 @@
TOOLS_PLATFORM.head?=          /usr/bin/head
TOOLS_PLATFORM.hostname?=      /bin/hostname
TOOLS_PLATFORM.id?=            /usr/xpg4/bin/id
+.if exists(/usr/ucb/install)
TOOLS_PLATFORM.install?=       /usr/ucb/install
+.elif exists(/usr/bin/ginstall)
+TOOLS_PLATFORM.install?=       /usr/bin/ginstall
+.endif
TOOLS_PLATFORM.ln?=            /usr/bin/ln
TOOLS_PLATFORM.ls?=            /usr/bin/ls
TOOLS_PLATFORM.m4?=            /usr/ccs/bin/m4

(I realize that one could also install the SUNWscpu package provided by
Sun, and I assume that's what other users have been doing, but given a
few tweaks that doesn't seem necessary, hence this PR and also 39235.)


>Unformatted:
 >phase