pkg/39165: inn doesn't handle its own pkg variable INN_PATHBIN

[gcw%primenet.com.au@localhost]

>Number:         39165
>Category:       pkg
>Synopsis:       inn doesn't create a correct package +CONTENTS / PLIST
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 18 05:30:00 +0000 2008
>Originator:     Geoff C. Wing
>Release:        NetBSD 4.99.70
>Organization:
>Environment:
System: NetBSD g.primenet.com.au 4.99.70 NetBSD 4.99.70 (G) #1: Fri Jul 18 
12:49:52 EST 2008 
gcw%g.primenet.com.au@localhost:/usr/netbsd/src/sys/arch/i386/compile/G i386
Architecture: i386
Machine: i386
>Description:
        Inn uses INN_PATHBIN to install binaries.  It doesn't use it
        in its own PLIST so if you set INN_PATHBIN to something other
        than the default it will not record the installation correctly.

>How-To-Repeat:
        Set INN_PATHBIN to something other than default.  Install.  Watch
>Fix:

Someone with a clue should check this.  I don't know if it can
be done if INN_PATHBIN is outside the PREFIX hierarchy.  "make print-PLIST"
gave different results to the pkg_install tools.
        
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/news/inn/Makefile,v
retrieving revision 1.88
diff -u -r1.88 Makefile
--- Makefile    23 Jun 2008 09:10:53 -0000      1.88
+++ Makefile    18 Jul 2008 05:17:26 -0000
@@ -21,6 +21,8 @@
 
 MESSAGE_SUBST+=                INN_PATHBIN=${INN_PATHBIN:Q}
 
+PLIST_SUBST+=          INN_PATHBIN=${INN_PATHBIN:C|^${PREFIX}/||}
+
 GNU_CONFIGURE=         YES
 GNU_CONFIGURE_PREFIX=  ${INN_PREFIX}
 GNU_CONFIGURE_MANDIR=  ${PREFIX}/${PKGMANDIR}


Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/news/inn/PLIST,v
retrieving revision 1.12
diff -u -r1.12 PLIST
--- PLIST       23 Jun 2008 09:10:53 -0000      1.12
+++ PLIST       18 Jul 2008 05:19:33 -0000
@@ -1,134 +1,108 @@
-@comment $NetBSD: PLIST,v 1.12 2008/06/23 09:10:53 spz Exp $
-include/inn/config.h
-include/inn/dbz.h
-include/inn/libinn.h
-include/inn/storage.h
-libexec/inn/actmerge
-libexec/inn/actsync
-libexec/inn/actsyncd
-libexec/inn/archive
-libexec/inn/auth/passwd/auth_smb
-libexec/inn/auth/passwd/ckpasswd
-libexec/inn/auth/passwd/radius
-libexec/inn/auth/resolv/domain
-libexec/inn/auth/resolv/ident
-libexec/inn/batcher
-libexec/inn/buffchan
-libexec/inn/cnfsheadconf
-libexec/inn/cnfsstat
-sbin/cnfsstat
-libexec/inn/control/checkgroups.pl
-libexec/inn/control/ihave.pl
-libexec/inn/control/newgroup.pl
-libexec/inn/control/rmgroup.pl
-libexec/inn/control/sendme.pl
-libexec/inn/control/sendsys.pl
-libexec/inn/control/senduuname.pl
-libexec/inn/control/version.pl
-libexec/inn/controlbatch
-libexec/inn/controlchan
-libexec/inn/convdate
-libexec/inn/ctlinnd
-sbin/ctlinnd
-libexec/inn/cvtbatch
-libexec/inn/docheckgroups
-libexec/inn/expire
-libexec/inn/expireover
-libexec/inn/expirerm
-libexec/inn/fastrm
-libexec/inn/filechan
-libexec/inn/filter/INN.py
-libexec/inn/filter/filter.tcl
-libexec/inn/filter/filter_innd.pl
-libexec/inn/filter/filter_innd.py
-libexec/inn/filter/filter_nnrpd.pl
-libexec/inn/filter/nnrpd_access.pl
-libexec/inn/filter/nnrpd_auth.pl
-libexec/inn/filter/nnrpd_auth.py
-libexec/inn/filter/startup.tcl
-libexec/inn/filter/startup_innd.pl
-libexec/inn/getlist
-libexec/inn/gpgverify
-libexec/inn/grephistory
-libexec/inn/imapfeed
-libexec/inn/inews
+@comment $NetBSD$
+${INN_PATHBIN}/actmerge
+${INN_PATHBIN}/actsync
+${INN_PATHBIN}/actsyncd
+${INN_PATHBIN}/archive
+${INN_PATHBIN}/auth/passwd/auth_smb
+${INN_PATHBIN}/auth/passwd/ckpasswd
+${INN_PATHBIN}/auth/passwd/radius
+${INN_PATHBIN}/auth/resolv/domain
+${INN_PATHBIN}/auth/resolv/ident
+${INN_PATHBIN}/batcher
+${INN_PATHBIN}/buffchan
+${INN_PATHBIN}/cnfsheadconf
+${INN_PATHBIN}/cnfsstat
+${INN_PATHBIN}/control/checkgroups.pl
+${INN_PATHBIN}/control/ihave.pl
+${INN_PATHBIN}/control/newgroup.pl
+${INN_PATHBIN}/control/rmgroup.pl
+${INN_PATHBIN}/control/sendme.pl
+${INN_PATHBIN}/control/sendsys.pl
+${INN_PATHBIN}/control/senduuname.pl
+${INN_PATHBIN}/control/version.pl
+${INN_PATHBIN}/controlbatch
+${INN_PATHBIN}/controlchan
+${INN_PATHBIN}/convdate
+${INN_PATHBIN}/ctlinnd
+${INN_PATHBIN}/cvtbatch
+${INN_PATHBIN}/docheckgroups
+${INN_PATHBIN}/expire
+${INN_PATHBIN}/expireover
+${INN_PATHBIN}/expirerm
+${INN_PATHBIN}/fastrm
+${INN_PATHBIN}/filechan
+${INN_PATHBIN}/filter/INN.py
+${INN_PATHBIN}/filter/filter.tcl
+${INN_PATHBIN}/filter/filter_innd.pl
+${INN_PATHBIN}/filter/filter_innd.py
+${INN_PATHBIN}/filter/filter_nnrpd.pl
+${INN_PATHBIN}/filter/nnrpd_access.pl
+${INN_PATHBIN}/filter/nnrpd_auth.pl
+${INN_PATHBIN}/filter/nnrpd_auth.py
+${INN_PATHBIN}/filter/startup.tcl
+${INN_PATHBIN}/filter/startup_innd.pl
+${INN_PATHBIN}/getlist
+${INN_PATHBIN}/gpgverify
+${INN_PATHBIN}/grephistory
+${INN_PATHBIN}/imapfeed
+${INN_PATHBIN}/inews
+${INN_PATHBIN}/inncheck
+${INN_PATHBIN}/innconfval
+${INN_PATHBIN}/innd
+${INN_PATHBIN}/inndf
+${INN_PATHBIN}/inndstart
+${INN_PATHBIN}/innfeed
+${INN_PATHBIN}/innmail
+${INN_PATHBIN}/innreport
+${INN_PATHBIN}/innstat
+${INN_PATHBIN}/innupgrade
+${INN_PATHBIN}/innwatch
+${INN_PATHBIN}/innxbatch
+${INN_PATHBIN}/innxmit
+${INN_PATHBIN}/mailpost
+${INN_PATHBIN}/makedbz
+${INN_PATHBIN}/makehistory
+${INN_PATHBIN}/mod-active
+${INN_PATHBIN}/news.daily
+${INN_PATHBIN}/news2mail
+${INN_PATHBIN}/ninpaths
+${INN_PATHBIN}/nnrpd
+${INN_PATHBIN}/nntpget
+${INN_PATHBIN}/nntpsend
+${INN_PATHBIN}/ovdb_init
+${INN_PATHBIN}/ovdb_monitor
+${INN_PATHBIN}/ovdb_server
+${INN_PATHBIN}/ovdb_stat
+${INN_PATHBIN}/overchan
+${INN_PATHBIN}/perl-nocem
+${INN_PATHBIN}/pgpverify
+${INN_PATHBIN}/procbatch
+${INN_PATHBIN}/prunehistory
+${INN_PATHBIN}/pullnews
+${INN_PATHBIN}/rc.news
+${INN_PATHBIN}/rnews
+${INN_PATHBIN}/rnews.libexec/c7unbatch
+${INN_PATHBIN}/rnews.libexec/decode
+${INN_PATHBIN}/rnews.libexec/encode
+${INN_PATHBIN}/rnews.libexec/gunbatch
+${INN_PATHBIN}/scanlogs
+${INN_PATHBIN}/scanspool
+${INN_PATHBIN}/send-ihave
+${INN_PATHBIN}/send-nntp
+${INN_PATHBIN}/send-uucp
+${INN_PATHBIN}/sendinpaths
+${INN_PATHBIN}/sendxbatches
+${INN_PATHBIN}/shlock
+${INN_PATHBIN}/shrinkfile
+${INN_PATHBIN}/signcontrol
+${INN_PATHBIN}/simpleftp
+${INN_PATHBIN}/sm
+${INN_PATHBIN}/startinnfeed
+${INN_PATHBIN}/tally.control
+${INN_PATHBIN}/tdx-util
+${INN_PATHBIN}/writelog
 bin/inews
-libexec/inn/inncheck
-libexec/inn/innconfval
-libexec/inn/innd
-libexec/inn/inndf
-libexec/inn/inndstart
-sbin/inndstart
-libexec/inn/innfeed
-libexec/inn/innmail
-libexec/inn/innreport
-libexec/inn/innstat
-libexec/inn/innupgrade
-libexec/inn/innwatch
-libexec/inn/innxbatch
-libexec/inn/innxmit
-libexec/inn/mailpost
-libexec/inn/makedbz
-libexec/inn/makehistory
-sbin/makehistory
-libexec/inn/mod-active
-libexec/inn/news.daily
-libexec/inn/news2mail
-libexec/inn/ninpaths
-libexec/inn/nnrpd
-libexec/inn/nntpget
-libexec/inn/nntpsend
-libexec/inn/ovdb_init
-libexec/inn/ovdb_monitor
-libexec/inn/ovdb_server
-libexec/inn/ovdb_stat
-libexec/inn/overchan
-libexec/inn/perl-nocem
-libexec/inn/pgpverify
-libexec/inn/procbatch
-libexec/inn/prunehistory
-libexec/inn/pullnews
-libexec/inn/rc.news
-libexec/inn/rnews
 bin/rnews
-libexec/inn/rnews.libexec/c7unbatch
-libexec/inn/rnews.libexec/decode
-libexec/inn/rnews.libexec/encode
-libexec/inn/rnews.libexec/gunbatch
-libexec/inn/scanlogs
-libexec/inn/scanspool
-libexec/inn/send-ihave
-libexec/inn/send-nntp
-libexec/inn/send-uucp
-libexec/inn/sendinpaths
-libexec/inn/sendxbatches
-libexec/inn/shlock
-libexec/inn/shrinkfile
-libexec/inn/signcontrol
-libexec/inn/simpleftp
-libexec/inn/sm
-libexec/inn/startinnfeed
-libexec/inn/tally.control
-libexec/inn/tdx-util
-libexec/inn/writelog
-share/doc/inn/CONTRIBUTORS
-share/doc/inn/GPL
-share/doc/inn/HACKING
-share/doc/inn/INSTALL
-share/doc/inn/LICENSE
-share/doc/inn/NEWS
-share/doc/inn/README
-share/doc/inn/TODO
-share/doc/inn/compliance-nntp
-share/doc/inn/config-design
-share/doc/inn/config-semantics
-share/doc/inn/config-syntax
-share/doc/inn/external-auth
-share/doc/inn/history
-share/doc/inn/hook-perl
-share/doc/inn/hook-python
-share/doc/inn/hook-tcl
-share/doc/inn/sample-control
 include/inn/conffile.h
 include/inn/config.h
 include/inn/dbz.h
@@ -271,6 +245,28 @@
 man/man8/tally.control.8
 man/man8/tdx-util.8
 man/man8/writelog.8
+sbin/cnfsstat
+sbin/ctlinnd
+sbin/inndstart
+sbin/makehistory
+share/doc/inn/CONTRIBUTORS
+share/doc/inn/GPL
+share/doc/inn/HACKING
+share/doc/inn/INSTALL
+share/doc/inn/LICENSE
+share/doc/inn/NEWS
+share/doc/inn/README
+share/doc/inn/TODO
+share/doc/inn/compliance-nntp
+share/doc/inn/config-design
+share/doc/inn/config-semantics
+share/doc/inn/config-syntax
+share/doc/inn/external-auth
+share/doc/inn/history
+share/doc/inn/hook-perl
+share/doc/inn/hook-python
+share/doc/inn/hook-tcl
+share/doc/inn/sample-control
 share/examples/inn/INN.py
 share/examples/inn/active.minimal
 share/examples/inn/actsync.cfg
@@ -316,14 +312,14 @@
 share/examples/inn/storage.conf
 share/examples/inn/subscriptions
 share/examples/rc.d/innd
+@dirrm ${INN_PATHBIN}/rnews.libexec
+@dirrm ${INN_PATHBIN}/filter
+@dirrm ${INN_PATHBIN}/control
+@dirrm ${INN_PATHBIN}/auth/resolv
+@dirrm ${INN_PATHBIN}/auth/passwd
+@dirrm ${INN_PATHBIN}/auth
+@dirrm ${INN_PATHBIN}
 @dirrm share/examples/inn
+@dirrm share/doc/inn
 @dirrm include/inn/inn
 @dirrm include/inn
-@dirrm share/doc/inn
-@dirrm libexec/inn/rnews.libexec
-@dirrm libexec/inn/filter
-@dirrm libexec/inn/control
-@dirrm libexec/inn/auth/resolv
-@dirrm libexec/inn/auth/passwd
-@dirrm libexec/inn/auth
-@dirrm libexec/inn