pkg/39129: devel/scmcvs does not work correctly on IRIX

[srcshelton%gmail.com@localhost]

>Number:         39129
>Category:       pkg
>Synopsis:       devel/scmcvs does not work correctly on IRIX
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 11 11:35:00 +0000 2008
>Originator:     Stuart Shelton
>Release:        pkgsrc latest from CVS
>Organization:
>Environment:
IRIX 6.5.30f; MIPSpro Compilers: Version 7.4.4m
>Description:

CVS (from scmcvs) builds correctly and appears to pass its test-suite (although 
this doesn't appear to actually perform any tests...).  However, when I use it 
to try to sync pkgsrc I always get:

netbsd@fuel ~ # cd /usr/bsd/src && 
CVSROOT="anoncvs%anoncvs.netbsd.org@localhost:/cvsroot" CVS_RSH="ssh" 
/usr/bsd/bin/cvs update -dP
? BUILDING
? INDEX
? Makefile.inc
? PKGDB
? UPDATING
cvs update: Updating .
cvs update: Updating archivers
cvs update: Updating archivers/9e
<...>
cvs update: Updating archivers/unshield/patches
cvs update: Updating archivers/unzip
cvs [update aborted]: cannot open file Makefile for comparing: Permission denied


... whilst with another CVS, it works correctly:

<...>

cvs update: Updating archivers/unshield/patches
cvs update: Updating archivers/unzip
M archivers/unzip/Makefile
cvs update: Updating archivers/unzip/files
cvs update: Updating archivers/unzip/patches

... so something happened there, but the pkgsrc cvs didn't like it.

To be clear, every file & directory (named Makefile or otherwise) are all owned 
by the same user and have full permissions for that user:

netbsd@fuel ~ # find /usr/bsd/src/ -name Makefile -exec ls -l {} \; | cut -d" " 
-f 1,3-4 | sort | uniq
-rw-rw-r-- netbsd netbsd

>How-To-Repeat:

After the above, running pkgsrc cvs again results in:

<...>
cvs update: Updating archivers/unshield/patches
cvs update: Updating archivers/unzip
cvs [update aborted]: cannot open file Makefile for comparing: Permission denied

... this file is (presumably):

netbsd@fuel ~ # ls -l archivers/unzip/Makefile
-rw-r--r-- 1 netbsd netbsd 1.6K 2008-03-24 05:07 archivers/unzip/Makefile

netbsd@fuel ~ # cat archivers/unzip/Makefile
# $NetBSD: Makefile,v 1.69 2008/03/23 13:05:31 tron Exp $

DISTNAME=       unzip552
PKGNAME=        unzip-5.52
PKGREVISION=    4
CATEGORIES=     archivers
MASTER_SITES=   ftp://ftp.info-zip.org/pub/infozip/src/
EXTRACT_SUFX=   .tgz

MAINTAINER=     wiz%NetBSD.org@localhost
HOMEPAGE=       http://www.info-zip.org/pub/infozip/UnZip.html
COMMENT=        List, test and extract compressed files in a ZIP archive

PKG_INSTALLATION_TYPES= overwrite pkgviews
PKG_DESTDIR_SUPPORT=    user-destdir

DIST_SUBDIR=    ${PKGNAME_NOREV}        # Remove on next update.
WRKSRC=         ${WRKDIR}/${PKGNAME_NOREV}
USE_TOOLS+=     gmake

.include "../../mk/bsd.prefs.mk"

MAKE_FILE=      unix/Makefile
BUILD_TARGET=   generic_zlib unzipsfx
.if ${OPSYS:M*BSD} != "" || ${OPSYS} == "Darwin"
CFLAGS+=        -DBSD
.endif
CFLAGS+=        -I. -DUNIX -Dunix -DUSE_UNSHRINK
MAKE_FLAGS+=    CF=${CPPFLAGS:Q}\ ${CFLAGS:Q}
MAKE_FLAGS+=    LF2=${_STRIPFLAG_CC:Q}\ ${LDFLAGS:Q}\ -lz

#LDFLAGS.IRIX+= -lmp

INSTALLATION_DIRS=      bin ${PKGMANDIR}/man1 share/doc

TEST_TARGET=    check

do-install:
        cd ${WRKSRC} && ${INSTALL_PROGRAM} unzip funzip unzipsfx 
${DESTDIR}${PREFIX}/bin
        ${LN} -sf unzip ${DESTDIR}${PREFIX}/bin/zipinfo
        cd ${WRKSRC}/unix && ${INSTALL_SCRIPT} zipgrep ${DESTDIR}${PREFIX}/bin
        cd ${WRKSRC}/man && ${INSTALL_MAN} funzip.1 unzip.1 unzipsfx.1 \
                zipgrep.1 zipinfo.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
        ${INSTALL_DATA_DIR} ${DESTDIR}${PREFIX}/share/doc/unzip
        cd ${WRKSRC} && ${INSTALL_DATA} BUGS LICENSE README WHERE \
                ${DESTDIR}${PREFIX}/share/doc/unzip
        cd ${WRKSRC} && ${INSTALL_DATA} COPYING.OLD \
                ${DESTDIR}${PREFIX}/share/doc/unzip/COPYING

.include "../../devel/zlib/buildlink3.mk"
.include "../../mk/bsd.pkg.mk"

... so this error is definitely spurious.
>Fix:

After deleting archivers/unzip/Makefile, pkgsrc cvs can continue... but then 
breaks on audio/gqmpeg/Makefile, then audio/gqmpeg-devel/Makefile, then 
audio/libao/Makefile.common...

All of these files do exist, but are readable and writeable by the user running 
cvs - and so far the problem only seems to occur with Makefiles rather any of 
the other files within the package directories.

Very strange...

(The working cvs is 1.11.20, the broken pkgsrc cvs is 1.11.22)