pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/38946: weechat: add perl and ruby plugin support



>Number:         38946
>Category:       pkg
>Synopsis:       weechat: add perl and ruby plugin support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 12 14:50:00 +0000 2008
>Originator:     Zak B. Elep
>Release:        CURRENT
>Organization:
>Environment:
Darwin alteran.local 8.11.1 Darwin Kernel Version 8.11.1: Wed Oct 10 18:23:28 
PDT 2007; root:xnu-792.25.20~1/RELEASE_I386 i386 i386
>Description:
I'm using pkgsrc on a Macbook (I used MacPorts previously,) and I wanted to use 
chat/weechat as my IRC client.  However, in my previous installation I used 
WeeChat's Perl plugin, and now in pkgsrc chat/weechat it has does not have Perl 
plugin enabled, due to this bit in the Makefile:

CONFIGURE_ARGS+=        --disable-ruby --disable-perl --disable-aspell

I understand that this line also stops Ruby support, which would have been nice 
too.  So, I would like chat/weechat to have optional Perl and Ruby support just 
like what it currently does for Python and Lua (as seen in `bmake 
show-options`.)

>How-To-Repeat:
1. cd pkgsrc/chat/weechat
2. bmake install clean clean-depends
3. weechat-curses
4. '/perl' or '/ruby' on WeeChat's command/chat buffer
5. Output from #4: 'WeeChat Error: unknown command "perl" (type /help for 
help).'  This should not be the case if Perl support was enabled.

>Fix:
1. Remove `--disable-{perl,ruby}' in Makefile's CONFIGURE_ARGS
2. Add a block in options.mk to support Perl and Ruby, similar to Python:

.if !empty(PKG_OPTIONS:Mperl)
.include "../../lang/perl5/buildlink3.mk"
CONFIGURE_ARGS+=        --enable-perl
PLIST.python=           yes
.else
CONFIGURE_ARGS+=        --disable-perl
.endif

.if !empty(PKG_OPTIONS:Mruby)
.include "../../lang/ruby/buildlink3.mk"
CONFIGURE_ARGS+=        --enable-ruby
PLIST.python=           yes
.else
CONFIGURE_ARGS+=        --disable-ruby
.endif

3. Double check.  I'm probably missing something here.



Home | Main Index | Thread Index | Old Index