pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/38484: pkgsrc pixman-0.10.0 is using non-portable gcc option



The following reply was made to PR pkg/38484; it has been noted by GNATS.

From: SODA Noriyuki <soda%sra.co.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
        pkgsrc-bugs%NetBSD.org@localhost
Subject: Re: pkg/38484: pkgsrc pixman-0.10.0 is using non-portable gcc option
Date: Wed, 23 Apr 2008 13:25:55 +0900

 It seems the following patch is needed too.
 Otherwise symbol pixman_have_sse() becomes undefined on my machine:
 
 --- pixman-0.10.0/pixman/pixman-pict.c.ORG     2008-04-23 13:17:17.000000000 
+0900
 +++ pixman-0.10.0/pixman/pixman-pict.c 2008-04-23 13:22:27.000000000 +0900
 @@ -1753,7 +1753,7 @@
  }
  
  
 -#ifdef USE_MMX
 +#if defined(USE_MMX) || defined(USE_SSE2)
  /* The CPU detection code needs to be in a file not compiled with
   * "-mmmx -msse", as gcc would generate CMOV instructions otherwise
   * that would lead to SIGILL instructions on old CPUs that don't have
 @@ -1935,6 +1935,7 @@
      return features;
  }
  
 +#ifdef USE_MMX
  pixman_bool_t
  pixman_have_mmx (void)
  {
 @@ -1950,6 +1951,7 @@
  
      return mmx_present;
  }
 +#endif
  
  #ifdef USE_SSE2
  pixman_bool_t
 


Home | Main Index | Thread Index | Old Index