pkg/38250: pkgsrc bootstrap broken due to compile error in pkg_install, at least on OS X

[chneukirchen%gmail.com@localhost]

>Number:         38250
>Category:       pkg
>Synopsis:       pkgsrc bootstrap broken due to compile error in pkg_install, 
>at least on OS X
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 17 01:10:00 +0000 2008
>Originator:     Christian Neukirchen
>Release:        pkgsrc HEAD as of 2008-03-17
>Organization:
anarchaia.org
>Environment:
Darwin lamia 9.1.0 Darwin Kernel Version 9.1.0: Wed Oct 31 17:46:22 PDT 2007; 
root:xnu-1228.0.2~1/RELEASE_I386 i386


>Description:
Bootstrapping pkgsrc on OS X 10.5 fails on building pkg_install due to an 
undefined symbol.



>How-To-Repeat:
pkgsrc/bootstrap% ./bootstrap --ignore-case-check --unprivileged 
--prefix=/Users/chris/mess/current/pkg
...
gcc -isystem /usr/include -L../libnbcompat -L../../libnbcompat -L../lib -o 
pkg_admin check.o config.o main.o -linstall -ltermcap -lnbcompat
Undefined symbols:
  "_gpg_cmd", referenced from:
      _config_variables in config.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
*** Error code 1

Stop.
bmake: stopped in 
/Users/chris/mess/current/pkgsrc/bootstrap/work/pkg_install/admin
*** Error code 1

Stop.
bmake: stopped in /Users/chris/mess/current/pkgsrc/bootstrap/work/pkg_install
===> exited with status 1
aborted.

% gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5465)


>Fix:
Index: pkgtools/pkg_install/files/admin/config.c
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/admin/config.c,v
retrieving revision 1.1
diff -u -r1.1 config.c
--- pkgtools/pkg_install/files/admin/config.c   13 Mar 2008 16:35:30 -0000      
1.1
+++ pkgtools/pkg_install/files/admin/config.c   16 Mar 2008 22:02:27 -0000
@@ -50,6 +50,7 @@
 #include "admin.h"
 #include "lib.h"
 
+const char *gpg_cmd;
 const char *pkg_vulnerabilities_dir;
 const char *pkg_vulnerabilities_file;
 const char *pkg_vulnerabilities_url;