pkg/38036: squid startup rc-file broken in pkgsrc-2007Q4

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

>Number:         38036
>Category:       pkg
>Synopsis:       squid startup rc-file broken in pkgsrc-2007Q4
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 15 13:45:00 +0000 2008
>Originator:     Wolfgang Stukenbrock
>Release:        pkgsrc-2007Q4
>Organization:
Dr. Nagler & Company GmbH
        
>Environment:
        
        
System: NetBSD s011 3.0 NetBSD 3.0 (NSW-S011) #19: Tue May 23 17:30:30 CEST 
2006 
wgstuken@s012:/export/NetBSD-3.0/N+C-build/.OBJDIR_i386/export/NetBSD-3.0/src/sys/arch/i386/compile/NSW-S011
 i386
Architecture: i386
Machine: i386
>Description:
        In the file installed in /etc/rc.d/squid a variable "start_cmd" is
        referenced in the "createdirs" target and in the non-Netbsd startup.
        Since pkgsrc-2007Q1 the definition for this variable ist lost in this
        file. So the createdirs target will not work on any system anymore, and
        squid cannot be started using this file on any non-NetBSD system.
>How-To-Repeat:
        Install www/squid and try to create the squid directories using
        /etc/rc.d/squid createdirs. It will fail with the message "-z not 
found",
        as long as no "-z" binary is on the current path.
>Fix:
        Undo the changes in the startup file since pkgsrc-2007Q1.
        The affected file is /usr/pkgsrc/www/squid/files/squid.sh.

        The following patch will reinsert the missing definition.
*** squid.sh.orig       Fri Feb 15 14:29:29 2008
--- squid.sh    Fri Feb 15 14:31:06 2008
***************
*** 16,21 ****
--- 16,22 ----
  required_files="${conf_file} @PKG_SYSCONFDIR@/mime.conf"
  command_args="-Y -f $conf_file"
  
+ start_cmd="${command} ${command_args}"
  stop_cmd="stop_nicely"
  kill_command="${command} -k shutdown"
  reload_cmd="${command} -k reconfigure"

>Unformatted: