pkg/37855: comms/jpilot does not compile on Darwin

[bsd%cs.ubc.ca@localhost]

>Number:         37855
>Category:       pkg
>Synopsis:       comms/jpilot does not compile on Darwin
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 23 20:20:00 +0000 2008
>Originator:     Brian de Alwis
>Release:        n/a
>Organization:
>Environment:
Darwin 9.1.0 (Mac OS X 10.5.1)
>Description:
The attached patch fixes two problems with the build, and also includes a 
header files required to build jpilot plugins.

Fix 1. comms/jpilot requires gmake to build.

Fix 2. The Makefile explicitly sets LDFLAGS=-export-dynamic which is not 
supported on Darwin/Mac OS X.

The attached patch also causes config.h to be installed as it is required by 
libplugin.h.  It has some useful defines for plugins such as PACKAGE, 
PACKAGE_BUGREPORT, PACKAGE_NAME, PACKAGE_STRING, PACKAGE_VERSION, and PROGNAME.
>How-To-Repeat:

>Fix:
=== modified file 'comms/jpilot/Makefile'
--- comms/jpilot/Makefile       2008-01-09 15:38:08 +0000
+++ comms/jpilot/Makefile       2008-01-20 19:37:16 +0000
@@ -16,13 +16,18 @@
 USE_PKGLOCALEDIR=      YES
 USE_OLD_DES_API=       YES
 USE_DIRS+=             xdg-1.4
-USE_TOOLS+=            intltool msgfmt pkg-config
+USE_TOOLS+=            intltool msgfmt pkg-config gmake
 USE_LANGUAGES+=                c
 
 GNU_CONFIGURE=         YES
 CONFIGURE_ARGS+=       --with-gtk-prefix="${BUILDLINK_PREFIX.gtk2}"
 CONFIGURE_ARGS+=       
--with-pilot-prefix="${BUILDLINK_PREFIX.pilot-link-libs}"
+
+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} != "Darwin"
 LDFLAGS+=              -export-dynamic
+.endif
 
 DOCDIR=                        ${PREFIX}/share/doc/jpilot
 INCDIR=                        ${PREFIX}/include/jpilot
@@ -48,7 +53,7 @@
        ${INSTALL_DATA_DIR} ${DOCDIR}
        ${INSTALL_DATA_DIR} ${INCDIR}
        ${INSTALL_DATA_DIR} ${PLUGINSDIR}
-       cd ${WRKSRC}; ${INSTALL_DATA} libplugin.h prefs.h ${INCDIR}
+       cd ${WRKSRC}; ${INSTALL_DATA} config.h libplugin.h prefs.h ${INCDIR}
        ${INSTALL_DATA} ${WRKSRC}/BUGS ${DOCDIR}
        cd ${WRKSRC}/docs; ${INSTALL_MAN} *.1 ${MAN1DIR}
        ${TOUCH} ${PLUGINSDIR}/.directory

=== modified file 'comms/jpilot/PLIST'
--- comms/jpilot/PLIST  2008-01-09 15:38:08 +0000
+++ comms/jpilot/PLIST  2008-01-23 19:59:16 +0000
@@ -2,6 +2,7 @@
 bin/jpilot
 bin/jpilot-dump
 bin/jpilot-sync
+include/jpilot/config.h
 include/jpilot/libplugin.h
 include/jpilot/prefs.h
 lib/jpilot/plugins/.directory