pkg/37806: boostrap fails if there is a directory named awk/tar/pax/ln... in directory listed in PATH

[cheusov%tut.by@localhost]

>Number:         37806
>Category:       pkg
>Synopsis:       boostrap fails if there is a directory named awk/tar/pax/ln... 
>in directory listed in PATH
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 19 11:45:00 +0000 2008
>Originator:     cheusov%tut.by@localhost
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD chen.chizhovka.net 4.0_STABLE NetBSD 4.0_STABLE (GENERIC) #2: 
Tue Dec 25 17:42:38 EET 2007 
cheusov%chen.chizhovka.net@localhost:/srv/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
pkgsrc boostrap fails if there is a directory named awk/tar/pax/ln... in
directory listed in PATH. This happens because of bug in check_prog function in 
boostrap shell script. test -x is present but test -f is also needed.

log:
cheusov@chel>
1 bootstrap>./bootstrap --prefix /tmp/pkg --workdir /tmp/tmp --unprivileged
===> bootstrap command: ./bootstrap --prefix /tmp/pkg --workdir /tmp/tmp 
--unprivileged
===> bootstrap started: Ñáò ßíâ 19 13:43:14 EET 2008
Working directory is: /tmp/tmp
===> running: /bin/sed -e 's|@DEFAULT_INSTALL_MODE@|'0755'|' 
/srv/pkgsrc/sysutils/install-sh/files/install-sh.in > /tmp/tmp/bin/install-sh
===> running: /bin/chmod +x /tmp/tmp/bin/install-sh
./bootstrap: line 697: /home/cheusov/bin/awk: is a directory
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
===> building as unprivileged user cheusov/
===> Building libnbcompat
===> running: /bin/sh /tmp/tmp/bin/install-sh -d -o cheusov -g  
/tmp/tmp/libnbcompat
/bin/cp: target `/tmp/tmp/libnbcompat' is not a directory
===> running: (cd /tmp/tmp/libnbcompat; /bin/sh ./configure  -C 
--prefix=/tmp/pkg --mandir=/tmp/pkg/man --sysconfdir=/tmp/pkg/etc && make )
./bootstrap: line 221: cd: /tmp/tmp/libnbcompat: No such file or directory
/bin/sh: ./configure: No such file or directory
===> exited with status 127
aborted.

cheusov@chel>
1 bootstrap>

>Fix:
Either add test -d or use command 'which' or similar.