Re: pkg/36766: net/php-xmlrpc fails to build on freebsd

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/36766; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Yakovetsky Vladimir <yx%x.ua@localhost>
Subject: Re: pkg/36766: net/php-xmlrpc fails to build on freebsd
Date: Fri, 10 Aug 2007 17:57:27 +0200

 --VbJkn9YxBvnuCH5J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Fri, Aug 10, 2007 at 03:50:00PM +0000, Yakovetsky Vladimir wrote:
 > >Fix:
 > --- net/php-xmlrpc/Makefile.orig
 > +++ net/php-xmlrpc/Makefile
 > @@ -33,7 +33,11 @@
 >  
 >  .if !empty(USE_BUILTIN.iconv:M[nN][oO]) || \
 >      !empty(BUILTIN_LIB_FOUND.iconv:M[yY][eE][sS])
 > +.   if ${OPSYS} != "FreeBSD"
 >  CONFIGURE_ARGS+=    --with-iconv-dir=shared,${BUILDLINK_PREFIX.iconv}
 > +.   else
 > +CONFIGURE_ARGS+=    --with-iconv-dir=${BUILDLINK_PREFIX.iconv}
 > +.   endif
 >  .else
 >  CONFIGURE_ARGS+=    --with-iconv-dir
 >  .endif
 
 Hm. I don't like this conditionals. Does the attached version work for
 you?
 
 Joerg
 
 --VbJkn9YxBvnuCH5J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="Makefile.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/joerg/repo/netbsd/pkgsrc/net/php-xmlrpc/Makefile,v
 retrieving revision 1.8
 diff -u -r1.8 Makefile
 --- Makefile   22 Feb 2007 19:26:57 -0000      1.8
 +++ Makefile   10 Aug 2007 15:56:27 -0000
 @@ -31,9 +31,8 @@
  .include "../../converters/libiconv/builtin.mk"
  CHECK_BUILTIN.iconv:= no
  
 -.if !empty(USE_BUILTIN.iconv:M[nN][oO]) || \
 -    !empty(BUILTIN_LIB_FOUND.iconv:M[yY][eE][sS])
 -CONFIGURE_ARGS+=      --with-iconv-dir=shared,${BUILDLINK_PREFIX.iconv}
 +.if !empty(USE_BUILTIN.iconv:M[nN][oO])
 +CONFIGURE_ARGS+=      --with-iconv-dir=${BUILDLINK_PREFIX.iconv}
  .else
  CONFIGURE_ARGS+=      --with-iconv-dir
  .endif
 
 --VbJkn9YxBvnuCH5J--