pkg/36393: Bad use of LD_LIBRARY_PATH in seamonkey wrapper scripts

[Christian Biere <christianbiere%gmx.de@localhost>]

>Number:         36393
>Category:       pkg
>Synopsis:       Bad use of LD_LIBRARY_PATH in seamonkey wrapper scripts
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 28 16:20:00 +0000 2007
>Originator:     Christian Biere
>Release:        NetBSD 4.99.7
>Environment:
>Description:
The wrapper scripts for www/seamonkey and www/seamonkey-bin extend 
LD_LIBRARY_PATH
incorrectly, so that the current working directory is included in the directory 
list,
if this variable is not already set. Usually LD_LIBRARY_PATH is not set, thus 
it affects
most users.

>How-To-Repeat:
>Fix:

Index: www/seamonkey/files/mozilla-ELF.in
===================================================================
RCS file: /cvsroot/pkgsrc/www/seamonkey/files/mozilla-ELF.in,v
retrieving revision 1.2
diff -u -p -r1.2 mozilla-ELF.in
--- www/seamonkey/files/mozilla-ELF.in  4 Feb 2007 00:15:49 -0000       1.2
+++ www/seamonkey/files/mozilla-ELF.in  28 May 2007 16:08:10 -0000
@@ -1,6 +1,6 @@
 #!/bin/sh
 MOZILLA_FIVE_HOME=@PREFIX@/lib/@MOZILLA@
 export MOZILLA_FIVE_HOME
-LD_LIBRARY_PATH=@PREFIX@/lib/@MOZILLA@:@PREFIX@/lib:${LD_LIBRARY_PATH}
+LD_LIBRARY_PATH=@PREFIX@/lib/@MOZILLA@:@PREFIX@/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
 export LD_LIBRARY_PATH
 exec @PREFIX@/lib/@MOZILLA@/@MOZILLA_BIN@ "$@"
Index: www/seamonkey-bin/files/mozilla.sh
===================================================================
RCS file: /cvsroot/pkgsrc/www/seamonkey-bin/files/mozilla.sh,v
retrieving revision 1.1
diff -u -p -r1.1 mozilla.sh
--- www/seamonkey-bin/files/mozilla.sh  24 Sep 2006 16:35:39 -0000      1.1
+++ www/seamonkey-bin/files/mozilla.sh  28 May 2007 16:11:12 -0000
@@ -1,7 +1,7 @@
 #!@SH@
 # $NetBSD: mozilla.sh,v 1.1 2006/09/24 16:35:39 salo Exp $
 
-LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:@PREFIX@/lib/@MOZILLA@@MOZ_EXTRA@-@MOZ_PLATFORM@"
+LD_LIBRARY_PATH="${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}@PREFIX@/lib/@MOZILLA@@MOZ_EXTRA@-@MOZ_PLATFORM@"
 export LD_LIBRARY_PATH
 
 exec @PREFIX@/lib/@MOZILLA@@MOZ_EXTRA@-@MOZ_PLATFORM@/@MOZILLA@ "$@"