Re: pkg/18964 (SDL audio hangs parent thread when using esd)

[Cliff Wright <cliff%snipe444.org@localhost>]

The following reply was made to PR pkg/18964; it has been noted by GNATS.

From: Cliff Wright <cliff%snipe444.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/18964 (SDL audio hangs parent thread when using esd)
Date: Sun, 24 Sep 2006 19:56:58 -0700

 On Sun, 24 Sep 2006 18:29:40 +0000 (UTC)
 joerg%NetBSD.org@localhost wrote:
 
 > Synopsis: SDL audio hangs parent thread when using esd
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: joerg%netbsd.org@localhost
 > State-Changed-When: Sun, 24 Sep 2006 18:29:39 +0000
 > State-Changed-Why:
 > SDL was updated a number of time since the PR was submitted.
 > Is this issue still present?
 > 
 > 
 I don't have this at the moment, so will have to check.
 However this also required a change to falcons-eye that I only submitted
 to falcons-eye, not pkgsrc. I found this old patch which had few comments.
 I include this below.
 
 Return-Path: noreply%sourceforge.net@localhost
 Received: from localhost (localhost [::1])
        by vixen.snipe444.org (8.11.3nb1/8.11.3) with ESMTP id gA7K4ET08592
        for <cliff@localhost>; Thu, 7 Nov 2002 12:04:14 -0800 (PST)
 Received: from mail.snipe444.org [209.166.87.123]
        by localhost with POP3 (fetchmail-5.8.1)
        for cliff@localhost (single-drop); Thu, 07 Nov 2002 12:04:14 -0800 (PST)
 Received: from usw-sf-netmisc.sourceforge.net (usw-sf-sshgate.sourceforge.net 
[216.136.171.253])
        by cncware.cncware.com (8.11.6/8.11.6) with ESMTP id gA7J8bG02977
        for <cliff%snipe444.org@localhost>; Thu, 7 Nov 2002 11:08:38 -0800
 Received: from usw-sf-web2-b.sourceforge.net ([10.3.1.22] 
helo=usw-sf-web2.sourceforge.net)
        by usw-sf-netmisc.sourceforge.net with esmtp (Exim 3.22 #1 (Debian))
        id 189s18-0001MB-00; Thu, 07 Nov 2002 11:08:38 -0800
 Received: from nobody by usw-sf-web2.sourceforge.net with local (Exim 3.33 #1 
(Debian))
        id 189s18-0005l3-00; Thu, 07 Nov 2002 11:08:38 -0800
 To: noreply%sourceforge.net@localhost
 From: noreply%sourceforge.net@localhost
 Subject: [ falconseye-Bugs-635116 ] esd based player fix
 Message-Id: <E189s18-0005l3-00%usw-sf-web2.sourceforge.net@localhost>
 Date: Thu, 07 Nov 2002 11:08:38 -0800
 
 Bugs item #635116, was opened at 2002-11-07 11:06
 You can respond by visiting: 
 
https://sourceforge.net/tracker/?func=detail&atid=396496&aid=635116&group_id=29569
 
 Category: None
 Group: None
 Status: Open
 Resolution: None
 Priority: 5
 Submitted By: Nobody/Anonymous (nobody)
 Assigned to: Nobody/Anonymous (nobody)
 Summary: esd based player fix
 
 Initial Comment:
 When playing background music using an esd(esound)
 based player
 (timidity in esd mode in my case) The graphics thread
 hangs.
 
 The following patch fixed this. Also a patch for SDL on
 NetBSD for esd fixed a problem of sound effects hanging
 the graphics. Now I have both background, and sound
 effects playing at the same time on NetBSD!
 
 --- jtp_sdl.c.orig      Mon Jul  2 07:05:50 2001
 +++ jtp_sdl.c   Thu Nov  7 10:53:52 2002
 @@ -713,6 +713,8 @@
    }
    else if (jtp_sdl_music_player_pid == 0) /* Child
 thread */
    {
 +    int i;
 +
      /* Process the player options */
      sprintf(tempbuffer, playerstring, musicfilename);
      /* Get the path to the binary */
 @@ -759,6 +761,7 @@
        */
 
        /* Execute the player command */
 +      for(i = 0; i < 20; i++) close(i);
        if (execv(player_name, player_args) == -1)
        {
          /* Log the error */
 
 ----------------------------------------------------------------------
 
 Comment By: Nobody/Anonymous (nobody)
 Date: 2002-11-07 11:08
 
 Message:
 Logged In: NO 
 
 e-mail of submitter is cliff%snipe444.org@localhost
 
 ----------------------------------------------------------------------
 
 You can respond by visiting: 
 
https://sourceforge.net/tracker/?func=detail&atid=396496&aid=635116&group_id=29569