pkg/34167: meta-pkgs/xfce4-extras won't build on current (gcc4)

[kennethcf%earthlink.net@localhost]

>Number:         34167
>Category:       pkg
>Synopsis:       meta-pkgs/xfce4-extras won't build on current (gcc4)
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 08 20:45:00 +0000 2006
>Originator:     Kenneth Freidank
>Release:        i386 3.99.21
>Organization:
>Environment:
NetBSD papadog.genken 3.99.21 NetBSD 3.99.21 (XSPD) #0: Thu Jul 13 07:51:25 EST 
2006 solomon%papadog.genken@localhost:/usr/obj/sys/arch/i386/compile/XSPD i386

>Description:
xfce4 plug-in /usr/pkgsrc/sysutils/xfce4-diskperf-plugin fails to compile.

#make

 cc -DHAVE_CONFIG_H -I. -I.. -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.
buildlink/include -DGLX_GLXEXT_LEGACY -I/usr/pkgsrc/sysutils/xfce4-diskperf-plug
in/work/.buildlink/include/freetype2 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugi
n/work/.buildlink/include/xfce4 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/wor
k/.x11-buildlink/include -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buil
dlink/include/libxml2 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildli
nk/include/gtk-2.0 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildlink/
lib/gtk-2.0/include -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildlink
/include/pango-1.0 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildlink/
include/glib/glib-2.0 -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildli
nk/lib/glib-2.0/include -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.build
link/include/cairo -I/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.buildlink/
include/atk-1.0 -DXFCE_PANEL_THREADED=1 "-DXFCE_PANEL_LOCK()=gdk_threads_enter()
" "-DXFCE_PANEL_UNLOCK()=gdk_threads_leave()" -O2 -MT libdiskperf_la-devperf.lo 
-MD -MP -MF .deps/libdiskperf_la-devperf.Tpo -c devperf.c  -fPIC -DPIC -o .libs/
libdiskperf_la-devperf.o
devperf.c: In function 'DevGetPerfData':
devperf.c:267: error: storage size of 'drive' isn't known
devperf.c:271: error: 'HW_DISKSTATS' undeclared (first use in this function)
devperf.c:271: error: (Each undeclared identifier is reported only once
devperf.c:271: error: for each function it appears in.)
devperf.c:272: error: invalid application of 'sizeof' to incomplete type 'struct
 disk_sysctl' 
devperf.c:275: error: invalid application of 'sizeof' to incomplete type 'struct
 disk_sysctl' 
devperf.c:275: warning: division by zero
devperf.c:281: error: invalid use of undefined type 'struct disk_sysctl'
devperf.c:281: error: dereferencing pointer to incomplete type
devperf.c:282: error: invalid use of undefined type 'struct disk_sysctl'
devperf.c:282: error: dereferencing pointer to incomplete type
gmake[2]: *** [libdiskperf_la-devperf.lo] Error 1
gmake[2]: Leaving directory `/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/xfc
e4-diskperf-plugin-1.5/panel-plugin'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/xfc
e4-diskperf-plugin-1.5'
gmake: *** [all] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/sysutils/xfce4-diskperf-plugin
===> 
===> There was an error during the ``build'' phase.
===> Please investigate the following for more information:
===>      * log of the build
===>      * /usr/pkgsrc/sysutils/xfce4-diskperf-plugin/work/.work.log
===> 
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/sysutils/xfce4-diskperf-plugin
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/meta-pkgs/xfce4-extras

>How-To-Repeat:
#cd /usr/pkgsrc/meta-pkgs/xfce4-extras
#make package
...build proceeds until the compile error...
>Fix:
This is not a fix to the broken plug-in, but it allows the remaining xfce4 
plug-ins in the meta-package to build and install.

Comment out a line in the meta package Makefile 
"/usr/pkgsrc/meta-pkgs/xfce4-extras/Makefile"

Change from
.include "../../sysutils/xfce4-diskperf-plugin/buildlink3.mk"

Change to
#.include "../../sysutils/xfce4-diskperf-plugin/buildlink3.mk"