pkg/33254: default install of libao results in no audio output on NetBSD

[he%NetBSD.org@localhost]

>Number:         33254
>Category:       pkg
>Synopsis:       default install of libao results in no audio output on NetBSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 13 17:20:00 +0000 2006
>Originator:     Havard Eidnes
>Release:        NetBSD 3.99.17
>Organization:
        
>Environment:
System: NetBSD vestlia.uninett.no 3.99.17 NetBSD 3.99.17 (VESTLIA) #6: Mon Apr 
3 00:20:14 CEST 2006 
he%vestlia.uninett.no@localhost:/usr/obj/sys/arch/i386/compile/VESTLIA i386
Architecture: i386
Machine: i386
>Description:
        The default install of libao from pkgsrc-2006Q1 on NetBSD-current
        results in a library which neither supports the "sun" nor the
        "oss" output methods, both of which are apparently available and
        working on NetBSD.

>How-To-Repeat:
        Try to use ogg123 with an out-of-the-box pkgsrc installation,
        and watch it list only "null" as an available "live" output
        device type when started with "ogg123 --help".

>Fix:
        This patch to Makefile.common turns on the two missing
        output methods for me on NetBSD, and they both work as
        intended.  However, this is probably not a viable solution
        since pkgsrc tries to be cross-platform.

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/audio/libao/Makefile.common,v
retrieving revision 1.25
diff -u -r1.25 Makefile.common
--- Makefile.common     9 Mar 2006 21:04:40 -0000       1.25
+++ Makefile.common     13 Apr 2006 17:14:55 -0000
@@ -25,8 +25,8 @@
 CONFIGURE_ARGS+=       --disable-polyp
 CONFIGURE_ARGS+=       ENABLE_AIX_AUDIO=no
 CONFIGURE_ARGS+=       ENABLE_IRIX=no
-CONFIGURE_ARGS+=       ENABLE_OSS=no
-CONFIGURE_ARGS+=       ENABLE_SUN_AUDIO=no
+CONFIGURE_ARGS+=       ENABLE_OSS=yes
+CONFIGURE_ARGS+=       ENABLE_SUN_AUDIO=yes
 CONFIGURE_ARGS+=       ENABLE_MACOSX=no
 CONFIGURE_ARGS+=       ENABLE_SOLARIS=no

        Makefile.common includes ../../mk/oss.buildlink3.mk, but
        I'm unable to discern what the logic in that file is supposed
        to acheive, and in turn how it is supposed to influence
        the build of libao.