Re: pkg/30663: [patch] lang/sbcl - ASDF-INSTALL is broken out of the box

[Peter Schuller <peter.schuller%infidyne.com@localhost>]

The following reply was made to PR pkg/30663; it has been noted by GNATS.

From: Peter Schuller <peter.schuller%infidyne.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: jonb%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/30663: [patch] lang/sbcl - ASDF-INSTALL is broken out of the 
box
Date: Thu, 7 Jul 2005 22:03:22 +0200

 --sdtB3X0nJg68CQEu
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hello,
 
 >  The patch is not correct.  The Makefile should add "gtar" to USE_TOOLS,
 >  and then the program run by installer.lisp should unconditionally be
 >  replaced by ${GTAR}.
 
 Alright. Updated patch attached.
 
 >  Also, is it a run dependency or a build depedency (I obviously don't
 >  know anything about sbcl, that's why I'm leaving jonb to actually
 >  handle the PR)?  The PR made me think the former, but the name of the
 >  affected file (install.lisp) hints for the latter.
 
 It's a run-time dependency. ASDF-INSTALL (ASDF = Another System Definition
 Facility) is a rudimentary Lisp package system that allows ministrators
 to easily install additional packages, or users do to it themselves in ~.
 
 -- 
 / Peter Schuller, InfiDyne Technologies HB
 
 PGP userID: 0xE9758B7D or 'Peter Schuller 
<peter.schuller%infidyne.com@localhost>'
 Key retrieval: Send an E-Mail to getpgpkey%scode.org@localhost
 E-Mail: peter.schuller%infidyne.com@localhost Web: http://www.scode.org
 
 
 --sdtB3X0nJg68CQEu
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=sbcl-patch
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/sbcl/Makefile,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 Makefile
 --- Makefile   23 Jun 2005 03:00:20 -0000      1.1.1.1
 +++ Makefile   7 Jul 2005 20:01:35 -0000
 @@ -17,11 +17,16 @@
  # In addition, SBCL should also work on Linux, Darwin, Solaris,
  # FreeBSD, OpenBSD, and possibly Win32, OSF/1, HP-UX, and Irix.
  
 -USE_TOOLS+=           gmake
 +USE_TOOLS+=           gmake gtar
  PKG_INSTALLATION_TYPES=       overwrite pkgviews
  
  WRKSRC=                       ${WRKDIR}/${PKGNAME}/
  
 +SUBST_CLASSES+=         sbcl
 +SUBST_STAGE.sbcl=       post-patch
 +SUBST_FILES.sbcl=       ${WRKSCR}/contrib/asdf-install/installer.lisp
 +SUBST_SED.sbcl=         -e 's|darwin \"tar\"|darwin \"${GTAR}\"|g'
 +
  #
  # Bootstrap section.
  #
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/sbcl/distinfo,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 distinfo
 --- distinfo   23 Jun 2005 03:00:20 -0000      1.1.1.1
 +++ distinfo   7 Jul 2005 20:01:35 -0000
 @@ -6,3 +6,4 @@
  SHA1 (patch-aa) = 8f1c02fc96233af1063ca8dd62bc6033eb435db2
  SHA1 (patch-ab) = c52f6a54783fbc7e55f198a070430b4c7378e6e7
  SHA1 (patch-ac) = b814853d6259be62cd18a5b68760ec1db7efe634
 +SHA1 (patch-ad) = 52cd3605a93e12ddb042be62dddc4561a2ffd90b
 
 --sdtB3X0nJg68CQEu--