pkg/25282: make update UPDATE_TARGET=bin-install not working

[jukka-netbsd%2004.salmi.ch@localhost]

>Number:         25282
>Category:       pkg
>Synopsis:       make update UPDATE_TARGET=bin-install not working
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 22 15:01:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Jukka Salmi
>Release:        NetBSD 2.0C
>Organization:
>Environment:
System: NetBSD himo.salmi.ch 2.0C NetBSD 2.0C (GENERIC) #0: Mon Apr 19 23:42:44 
CEST 2004 
build%himo.salmi.ch@localhost:/build/nbsdc/usr/src/sys/arch/i386/compile/GENERIC
 i386
Architecture: i386
Machine: i386
>Description:
When setting UPDATE_TARGET=bin-install, make update doesn't work. Given three
packages a, b and c where b depends on a, c depends on b. If a is updated
and UPDATE_TARGET is set to bin-install, the following happens:
- all packages are removed (pkg_delete -f)
- package a is rebuilt from source (or a binary packages is installed if
  available)
- packages b and c are not reinstalled because real-su-bin-install calls
  'make clean' if 'make package' successfully returns (see line 4051 in
  pkgsrc/mk/bsd.pkg.mk), and so a/work/.DDIR is also removed.
>How-To-Repeat:
call 'make update UPDATE_TARGET=bin-install' for a package which has
dependencies. Those dependencies are not installed after the update.
>Fix:
Not sure, but real-su-bin-install should definitely not call 'make clean'
right after 'make package'.
>Release-Note:
>Audit-Trail:
>Unformatted: