Re: kern/60760: lpt(4) concurrency issues

["Taylor R Campbell via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/60760; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: Johann =?utf-8?Q?H=C3=B6pfner?= <hoepf%cit.tum.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/60760: lpt(4) concurrency issues
Date: Thu, 8 Oct 2026 15:54:06 +0000

 > Date: Thu, 24 Sep 2026 15:18:21 +0200
 > From: Johann H=C3=B6pfner <hoepf%cit.tum.de@localhost>
 >=20
 > > +out:	if (locked) {
 > > +		sc->sc_state &=3D LPT_WRITING;
 > > +		wakeup(&sc->sc_state);
 > > +	}
 > > +	splx(s);
 >=20
 > I believe you want to clear LPT_WRITING here. You are clearing all other
 > bits though.
 
 You would believe correctly.  Oops.
 
 > >  	return 0;
 >=20
 > Maybe return error here instead of 0.
 
 Yes, that sounds like a good idea!
 
 Thanks for the review!